New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773026 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Chrome Home] Progress bar background color is incorrect

Project Member Reported by mdjones@chromium.org, Oct 9 2017

Issue description

The progress bar background in Chrome Home should be the same color as the status bar. Since modern was introduced, this is now broken for non-themed pages.
 

Comment 1 by k...@chromium.org, Oct 11 2017

Labels: Fine-Pri-3.5
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63e867adc4e1ef1ae413e8f1bbc1c794eb0fe48a

commit 63e867adc4e1ef1ae413e8f1bbc1c794eb0fe48a
Author: Matthew Jones <mdjones@chromium.org>
Date: Wed Oct 11 20:58:30 2017

[Home] Fix theme color logic in progress bar

The check in ColorUtils does not account for incognito or changing
default theme color. This change replaces adds the relevant params
to the ColorUtils.isUsingDefaultToolbarColor so it retrieved the
correct color for the browser state.

BUG= 773026 

Change-Id: I7c3ddef2c7a23f40634c33451fb79addf1da3880
Reviewed-on: https://chromium-review.googlesource.com/713275
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508109}
[modify] https://crrev.com/63e867adc4e1ef1ae413e8f1bbc1c794eb0fe48a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchQuickActionControl.java
[modify] https://crrev.com/63e867adc4e1ef1ae413e8f1bbc1c794eb0fe48a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/63e867adc4e1ef1ae413e8f1bbc1c794eb0fe48a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/63e867adc4e1ef1ae413e8f1bbc1c794eb0fe48a/chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java
[modify] https://crrev.com/63e867adc4e1ef1ae413e8f1bbc1c794eb0fe48a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

Status: Fixed (was: Assigned)

Sign in to add a comment