Issue metadata
Sign in to add a comment
|
3.7%-83.6% regression in rasterize_and_record_micro.top_25 at 507309:507309 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 9 2017
According to chromeperf, there is only one CL in the range. https://bugs.chromium.org/p/chromium/issues/detail?id=773018 Can you check if your CL might be the cause?
,
Oct 9 2017
My CL makes us paint broken image icons more often than we did before, so the regression is plausible and also unavoidable (insofar as the test is probably inadvertently testing how we handle a lot of unavailable images on a page).
,
Oct 10 2017
Issue 773360 has been merged into this issue.
,
Oct 12 2017
Sheriff pass. This CL seem to have caused 245 alerts in the rasterize_and_record_micro.top_25 benchmark (pretty much on all bots). Assigning benchmark owner (vmpstr) to make a call. Looks like this is about broken images and specs compat. Don't know enough to make a call as a perf sheriff.
,
Oct 12 2017
+wkorman, are we still running these sets with some images unavailable? From the size and number of regressions and with comment #3 in mind, I would imagine it's only possible if we have a lot of broken images. I think this caught us in a state where we're updating the pagesets to be static and we need to start including more images, which should recover the regression. wkorman, wdyt?
,
Oct 12 2017
FTR the cl in question is https://chromium.googlesource.com/chromium/src/+/6abc19e88235609c7b8fc9df464beed2b667a773
,
Oct 12 2017
Yes, duping to a similar regression which is blocked on the work to restore images to all of the static pages in the top 25 page set. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 9 2017