New issue
Advanced search Search tips

Issue 773016 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 761120



Sign in to add a comment

Remove screenshot related methods from PaletteDelegate

Project Member Reported by kaznacheev@chromium.org, Oct 9 2017

Issue description

CaptureRegionMode and CaptureScreenAction currently use PaletteDelegate to initiate screenshot. They could access ScreenshotController directly.
 
Status: Assigned (was: Untriaged)
Blocking: 761120
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc622083527efd731c4d6f89bacd0dae3f9b508c

commit fc622083527efd731c4d6f89bacd0dae3f9b508c
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Thu Oct 12 20:07:38 2017

Remove screenshot related methods from PaletteDelegate

Make palette tools interact with ScreenshotController directly.

Bug:  773016 
Change-Id: If79a50689f3e9ee387f7a8c27fd0f302c646773a
Reviewed-on: https://chromium-review.googlesource.com/706950
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508421}
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/palette_delegate.h
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/system/palette/palette_tray_unittest.cc
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/system/palette/test_palette_delegate.cc
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/system/palette/test_palette_delegate.h
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/system/palette/tools/capture_region_mode.cc
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/system/palette/tools/capture_screen_action.cc
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/system/palette/tools/screenshot_unittest.cc
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/utility/screenshot_controller.cc
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/ash/utility/screenshot_controller.h
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/chrome/browser/ui/ash/palette_delegate_chromeos.cc
[modify] https://crrev.com/fc622083527efd731c4d6f89bacd0dae3f9b508c/chrome/browser/ui/ash/palette_delegate_chromeos.h

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89bc8c35b38bedf40bfdff6c809f619cd5126c32

commit 89bc8c35b38bedf40bfdff6c809f619cd5126c32
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Tue Oct 17 06:16:45 2017

Filter out ScreenshotToolTest for mus and mash

  --mash --test-launcher-filter-file=
  testing/buildbot/filters/ash_unittests_mash.filter
  --mus --test-launcher-filter-file=
  testing/buildbot/filters/ash_unittests_mus.filter

Bug:  773016 
Test: ash_unittests --gtest_filter=ScreenshotTool*
Change-Id: I38fdf03b3d88fe0a2a831b950f0e95cbf6f5afcc
Test: ash_unittests --gtest_filter=ScreenshotTool*
Test: ash_unittests --gtest_filter=ScreenshotTool*
Reviewed-on: https://chromium-review.googlesource.com/721603
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509294}
[modify] https://crrev.com/89bc8c35b38bedf40bfdff6c809f619cd5126c32/ash/system/palette/tools/screenshot_unittest.cc
[modify] https://crrev.com/89bc8c35b38bedf40bfdff6c809f619cd5126c32/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/89bc8c35b38bedf40bfdff6c809f619cd5126c32/testing/buildbot/filters/ash_unittests_mus.filter

Sign in to add a comment