New issue
Advanced search Search tips

Issue 773013 link

Starred by 2 users
Status: Fixed
Owner:
robertphillips@chromium.org
Closed: Oct 2017
Cc:
fmalita@chromium.org
reed@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Suppress color-profile* layout tests for upcoming Skia roll

Project Member Reported by robertphillips@chromium.org, Oct 9 2017 

The upcoming Skia roll contains:

https://skia-review.googlesource.com/c/skia/+/57282 (Disable deferred proxies a different way in Chrome) which causes imperceptible differences in the following layout tests:


virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png.html
virtual/gpu-rasterization/images/color-profile-background-image-cross-fade.html
virtual/gpu-rasterization/images/color-profile-mask-image-svg.html
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0ede55487a379cfe900c553c4f422ca299ad987

commit a0ede55487a379cfe900c553c4f422ca299ad987
Author: Robert Phillips <robertphillips@google.com>
Date: Tue Oct 10 12:05:34 2017

Suppress color-profile* layout tests for upcoming Skia roll

Bug:  773013 
Change-Id: I066ba1154059823eb2614efe82ee5afa37195c68
Reviewed-on: https://chromium-review.googlesource.com/706661
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#507641}
[modify] https://crrev.com/a0ede55487a379cfe900c553c4f422ca299ad987/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41d5a1c30234c0f3f6b0575346760b95f1c535bb

commit 41d5a1c30234c0f3f6b0575346760b95f1c535bb
Author: Robert Phillips <robertphillips@google.com>
Date: Wed Oct 25 00:57:54 2017

Remove suppressions for Skia rolls

Bug:  777375 ,  773013 
Change-Id: I3ce61c834c572fd112ad18c96b6e5d08f2b35da5
Reviewed-on: https://chromium-review.googlesource.com/735755
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511322}
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.png
[delete] https://crrev.com/9bce89359c786654e07c1b5017c8514d1875c206/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png

Comment 3 by robertphillips@chromium.org, Oct 25 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment