//extensions renderer has illegal includes and/or deps (e.g., including //chrome, including */browser/, etc.) We should clean those up.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca16965fb04f9ea845b162580e281cfa801398dd commit ca16965fb04f9ea845b162580e281cfa801398dd Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Oct 09 21:08:55 2017 [Extensions Cleanup] Remove unneeded illegal include mime_handler_view_container.cc included mime_handler_view_constants.h, which is defined in //extensions/browser, and thus illegal to include, but never used it. Remove the include. Bug: 773004 Change-Id: I210517c6f1985ee7c7a5f633a80e37ab14e74e8c Reviewed-on: https://chromium-review.googlesource.com/707358 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#507487} [modify] https://crrev.com/ca16965fb04f9ea845b162580e281cfa801398dd/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b186b6abb26a28137c97d870ec5ca0cfc0bad32 commit 4b186b6abb26a28137c97d870ec5ca0cfc0bad32 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Dec 13 05:12:59 2017 [Extensions] Update //extensions/DEPS include rules Update the include rules for //extensions. There are many test-only exceptions (including quite a few that violate layering). These rules are currently applied for all tests in //extensions, but most only need to be applied to //extensions/browser. Trim the //extensions/DEPS include list to only have includes that are included from multiple subdirectories, and move the rest into //extensions/browser/DEPS and //extensions/renderer/DEPS. Also remove a few includes that were no longer necessary, or didn't exist. Bug: 773004 Change-Id: Ib6e705faae4472369858102e8a9ebe555e2a8d66 Reviewed-on: https://chromium-review.googlesource.com/820937 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523693} [modify] https://crrev.com/4b186b6abb26a28137c97d870ec5ca0cfc0bad32/extensions/DEPS [modify] https://crrev.com/4b186b6abb26a28137c97d870ec5ca0cfc0bad32/extensions/browser/DEPS [modify] https://crrev.com/4b186b6abb26a28137c97d870ec5ca0cfc0bad32/extensions/renderer/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/feb76a68eb892a2f5b6550a746400e9b715147c3 commit feb76a68eb892a2f5b6550a746400e9b715147c3 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Jan 10 20:36:41 2018 [Extensions Cleanup] Remove bad deps exceptions There's an exception in apps/DEPS and extensions/browser/DEPS to allow chrome/browser/extensions/extension_test_message_listener.h, but this file was moved to extensions/test/. This also means the exception is no longer necessary. Remove it. Bug: 773004 Change-Id: I5fce84a12784945389c8391aacf7573a4c0004e6 Reviewed-on: https://chromium-review.googlesource.com/858165 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#528412} [modify] https://crrev.com/feb76a68eb892a2f5b6550a746400e9b715147c3/apps/DEPS [modify] https://crrev.com/feb76a68eb892a2f5b6550a746400e9b715147c3/extensions/browser/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a7bde518aeb8c80190401a79b11020a38c087e8 commit 1a7bde518aeb8c80190401a79b11020a38c087e8 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Jan 18 02:10:37 2018 [Extensions] Disallow ExtensionService includes from //extensions //extensions should not depend on //chrome at all. Currently, there are exceptions for tests, but these shouldn't really be allowed either. Remove extension_service.h from the list of test-allowed includes, and move the runtime_apitest to the chrome layer. This test fundamentally relies on Chrome concepts, so doesn't belong at the //extensions layer. Bug: 773004 Change-Id: I33933ef42cc1ec1e456adb557cb83a26292d6564 Reviewed-on: https://chromium-review.googlesource.com/857259 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530014} [rename] https://crrev.com/1a7bde518aeb8c80190401a79b11020a38c087e8/chrome/browser/extensions/api/runtime/runtime_apitest.cc [modify] https://crrev.com/1a7bde518aeb8c80190401a79b11020a38c087e8/chrome/test/BUILD.gn [modify] https://crrev.com/1a7bde518aeb8c80190401a79b11020a38c087e8/extensions/BUILD.gn [modify] https://crrev.com/1a7bde518aeb8c80190401a79b11020a38c087e8/extensions/browser/DEPS [modify] https://crrev.com/1a7bde518aeb8c80190401a79b11020a38c087e8/extensions/browser/api/bluetooth/bluetooth_apitest.cc [modify] https://crrev.com/1a7bde518aeb8c80190401a79b11020a38c087e8/extensions/browser/api/cast_channel/cast_channel_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f455a2cf3ded0690a2131af68ae2a9f6613af27 commit 4f455a2cf3ded0690a2131af68ae2a9f6613af27 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Jan 25 01:36:45 2018 [Extensions] Move TestExtensionDir to //extensions/test Move TestExtensionDir from //chrome/browser/extensions to //extensions/test. Bug: 773004 TBRs for #include updates: TBR=pfeldman@chromium.org (c/b/devtools) TBR=isherman@chromium.org (c/b/metrics) TBR=jialiul@chromium.org (c/b/safe_browsing) TBR=nasko@chromium.org (c/b/site_details_browsertest.cc) Change-Id: I099df815d73dbb3fd563b4e09f0058e8cb9530de Reviewed-on: https://chromium-review.googlesource.com/883945 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#531775} [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/BUILD.gn [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/api/declarative/declarative_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/api/extension_action/extension_action_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/api/runtime/runtime_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/api/web_request/web_request_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/api_binding_perf_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/browsertest_util_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/content_capabilities_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/content_script_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/crx_installer_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/extension_action_runner_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/extension_csp_bypass_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/extension_loading_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/extension_messages_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/extension_nacl_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/extension_service_unittest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/extension_storage_monitor_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/fetch_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/native_bindings_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/options_page_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/process_manager_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/extensions/wake_event_page_apitest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_browsertest_win.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/site_details_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/ui/extensions/hosted_app_browsertest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/extensions/BUILD.gn [modify] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/extensions/browser/DEPS [rename] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/extensions/test/test_extension_dir.cc [rename] https://crrev.com/4f455a2cf3ded0690a2131af68ae2a9f6613af27/extensions/test/test_extension_dir.h
Comment 1 by rdevlin....@chromium.org
, Oct 9 2017