//extensions/renderer:unit_tests depends on //extensions/browser: https://chromium.googlesource.com/chromium/src/+/65a99d9ed4a9cae65333473cbac890b3e9246b77/extensions/renderer/BUILD.gn#402 brettw@, I see you added a TODO (presumably as part of a gn migration); is there an existing bug this should be blocking (or duped into, if I missed an extensions/renderer-related one)?
I don't have any recollection of the details.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cf20f01eb4110592986c820a162aca5d65bc442 commit 5cf20f01eb4110592986c820a162aca5d65bc442 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Oct 10 14:25:04 2017 [Extensions Cleanup] Move console_apitest to extension_bindings_apitest There's a file in //extensions/renderer called console_apitest, containing a single test for the behavior of logging uncaught exceptions. This is a browser test that exercises end-to-end behavior of the bindings system, and is more logical with the rest of our bindings tests in extension_bindings_apitest.cc. Move it there. This also removes the only file including browser files in the renderer for extensions, so remove it as a dependency in the BUILD files. Bug: 772993 Change-Id: I3640ee34484e5dda20d432aa7b0023a5cb914984 Reviewed-on: https://chromium-review.googlesource.com/707589 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#507662} [modify] https://crrev.com/5cf20f01eb4110592986c820a162aca5d65bc442/chrome/browser/extensions/extension_bindings_apitest.cc [rename] https://crrev.com/5cf20f01eb4110592986c820a162aca5d65bc442/chrome/test/data/extensions/api_test/bindings/uncaught_exception_logging/content_script.js [rename] https://crrev.com/5cf20f01eb4110592986c820a162aca5d65bc442/chrome/test/data/extensions/api_test/bindings/uncaught_exception_logging/extension_page.html [rename] https://crrev.com/5cf20f01eb4110592986c820a162aca5d65bc442/chrome/test/data/extensions/api_test/bindings/uncaught_exception_logging/extension_page.js [rename] https://crrev.com/5cf20f01eb4110592986c820a162aca5d65bc442/chrome/test/data/extensions/api_test/bindings/uncaught_exception_logging/manifest.json [rename] https://crrev.com/5cf20f01eb4110592986c820a162aca5d65bc442/chrome/test/data/extensions/api_test/bindings/uncaught_exception_logging/test.js [modify] https://crrev.com/5cf20f01eb4110592986c820a162aca5d65bc442/extensions/BUILD.gn [modify] https://crrev.com/5cf20f01eb4110592986c820a162aca5d65bc442/extensions/renderer/BUILD.gn [delete] https://crrev.com/71db1a4f45ec56120650bf1025643e8f7da8f888/extensions/renderer/console_apitest.cc
Comment 1 by rdevlin....@chromium.org
, Oct 9 2017