We should put all static media test cases (https://cs.chromium.org/chromium/src/tools/perf/page_sets/tough_video_cases/, https://cs.chromium.org/chromium/src/tools/perf/page_sets/mse_cases/) into one folder, probably s.t like https://cs.chromium.org/chromium/src/tools/perf/page_sets/media_cases/ Once this is done, we can then add OWNERS file in page_sets/media_cases/ for media test owners (Caleb & John)
I will take this. Thanks for filing this!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b87365aa1d9c1f5df752ae70422f8a5d7ab28f8 commit 5b87365aa1d9c1f5df752ae70422f8a5d7ab28f8 Author: Caleb Rouleau <crouleau@chromium.org> Date: Tue Oct 31 23:37:36 2017 [Telemetry] Add MSE tests to media perf tests. Currently these tests only provide audio_time_to_play and video_time_to_play media metrics (along with generic cpu and memory metrics). Adding new metrics after these tests are committed simply means adding trace events to the product code and turning those into metrics in media_metric.html. In this way, the code I have added is just the scenarios. These scenarios are meant to be working examples that can be edited significantly in the future. That said, once this is committed, we're probably fine dropping the legacy mse_cases (since they are really flaky and haven't been finding any bugs.) These tests will be enough to cover them. Bug: 772971 ,713335 Change-Id: Ib2c32e4ab97738cc8d8e4b745b11820761213ad3 Reviewed-on: https://chromium-review.googlesource.com/733985 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#513002} [modify] https://crrev.com/5b87365aa1d9c1f5df752ae70422f8a5d7ab28f8/tools/perf/page_sets/tough_video_cases.py [add] https://crrev.com/5b87365aa1d9c1f5df752ae70422f8a5d7ab28f8/tools/perf/page_sets/tough_video_cases/aac_audio.mp4.sha1 [add] https://crrev.com/5b87365aa1d9c1f5df752ae70422f8a5d7ab28f8/tools/perf/page_sets/tough_video_cases/h264_video.mp4.sha1 [add] https://crrev.com/5b87365aa1d9c1f5df752ae70422f8a5d7ab28f8/tools/perf/page_sets/tough_video_cases/mse.html [add] https://crrev.com/5b87365aa1d9c1f5df752ae70422f8a5d7ab28f8/tools/perf/page_sets/tough_video_cases/mse.js [modify] https://crrev.com/5b87365aa1d9c1f5df752ae70422f8a5d7ab28f8/tools/perf/page_sets/tough_video_cases/video.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/606711ad92b376dff5442992f82d0907e1208acf commit 606711ad92b376dff5442992f82d0907e1208acf Author: Caleb Rouleau <crouleau@chromium.org> Date: Fri Nov 03 01:39:31 2017 Delete mse_cases leftover. I forgot to delete this in https://chromium-review.googlesource.com/733985 NOTRY=true # the CQ is very flaky, failing tests are not related to this change Bug: 772971 Change-Id: If2142b01459df4116660524c86b46d0a6b4bed3e Reviewed-on: https://chromium-review.googlesource.com/752575 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#513652} [delete] https://crrev.com/5bbd54701c09280bd60a0b079ce8648f7e9a1315/tools/perf/page_sets/mse_cases.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/315ab39662be6086b31d56c5a26190360c57e3ee commit 315ab39662be6086b31d56c5a26190360c57e3ee Author: Caleb Rouleau <crouleau@chromium.org> Date: Fri Nov 03 05:15:33 2017 Rename tough_video_cases to media_cases. Many of these test cases are audio-only. Many of them are not "tough". Also, add myself, John, and Dale as owners. Bug: 772971 Change-Id: Ib5c7742c84cc7c9374436c56d2faadb0841cc32a Reviewed-on: https://chromium-review.googlesource.com/752749 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#513694} [modify] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/benchmarks/media.py [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases.py [add] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/OWNERS [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/aac_audio.mp4.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/crowd.ogg.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/crowd1080.mp4.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/crowd1080.webm.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/crowd1080_vp9.webm.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/crowd2160.ogv.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/crowd360.mp4.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/crowd360.webm.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/crowd720_vp9.webm.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/garden2_10s.mp4.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/garden2_10s.webm.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/h264_video.mp4.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/mse.html [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/mse.js [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/smpte_3840x2160_60fps_vp9.webm.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/tulip2.m4a.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/tulip2.mp3.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/tulip2.mp4.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/tulip2.ogg.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/tulip2.vp9.webm.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/tulip2.wav.sha1 [rename] https://crrev.com/315ab39662be6086b31d56c5a26190360c57e3ee/tools/perf/page_sets/media_cases/video.html
Comment 1 by crouleau@chromium.org
, Oct 9 2017