New issue
Advanced search Search tips

Issue 772969 link

Starred by 2 users
Status: Assigned
Owner:
bsheedy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Update VR latency test runner to support VrCore settings modification

Project Member Reported by bsheedy@chromium.org, Oct 9 2017 
The test runner used for VR motion-to-photon latency tests was originally created assuming that the test device would be properly set up beforehand and stay constant. However, now that we are also running Telemetry tests on the same device, it's possible that the VrCore settings used for motopho tests will change between runs (most notably the paired headset).

The end goal would be to support the setting of VrCore preferences before running the test like Telemetry. However, this requires porting the test runner over to use Devil, which might take a bit of work to support.

A quick, temporary solution would be to have the Telemetry tests apply the Cardboard settings file after they are finished so that the device is always left in the same state after a test.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2be9755d11a58c4df25b33be8a1a9e3e08da0f5

commit d2be9755d11a58c4df25b33be8a1a9e3e08da0f5
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Oct 17 03:07:31 2017

Make VR Telemetry tests reset VrCore settings after running

Makes VR Telemetry tests set VrCore to use a Cardboard headset after
a benchmark is run. This is so that the device is left in a consistent
state after a benchmark regardless of what VrCore settings were used
during the test.

This is a temporary solution until the non-Telemetry VR tests (namely
latency) are ported to use Devil and can apply VrCore settings
themselves.

Bug: 772969
Change-Id: I79428963d4807613c0b1c59043cde63d07cdf0dd
Reviewed-on: https://chromium-review.googlesource.com/721573
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509254}
[modify] https://crrev.com/d2be9755d11a58c4df25b33be8a1a9e3e08da0f5/tools/perf/contrib/vr_benchmarks/shared_android_vr_page_state.py

Comment 2 by btebbs@chromium.org, Jul 4

Components: Internals>XR

Comment 3 by efoo@chromium.org, Aug 7 

Removing Internals>VR component and remapping to Internals>XR

Comment 4 by efoo@chromium.org, Aug 7

Components: -Internals>VR
►

Sign in to add a comment