New issue
Advanced search Search tips

Issue 772964 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Material chrome://flags: Esc doesn't leave search.

Project Member Reported by lgar...@chromium.org, Oct 9 2017

Issue description

Chrome 63.0.3236.0
macOS 10.12.6

What steps will reproduce the problem?
(1) Visit Material chrome://flags/
(2) Focus the search box
(3) Press Esc.

What is the expected result?
The search is canceled and all flags appear again.

What happens instead?
The search box stays highlighted.
 
Cc: edwardjung@chromium.org
Summary: Material chrome://flags: Esc doesn't leave search. (was: New chrome://flags/ : Esc doesn't leave search.)
Cc: -edwardjung@chromium.org
Owner: edwardjung@chromium.org
Status: Started (was: Untriaged)
I'll this in. 
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1a7f3f12e7748e6eeed536703972f2f79f1570e

commit d1a7f3f12e7748e6eeed536703972f2f79f1570e
Author: Edward Jung <edwardjung@chromium.org>
Date: Fri Oct 13 17:45:59 2017

chrome://flags Switch to global search + bug fixes

+ Switching to search across the experiment title, description and link.
+ Fix cancel button overlapping long search entries.
+ 'Esc' will now unfocus the search box.
+ Reinstate elided description text for small screen devices.
+ Searching will auto expand the descriptions.
+ Improvements to the layout on small screens.

Bug: 773973, 772964 
Change-Id: Ifa5efd126aea3df357b4498af91dea4fa523addb
Reviewed-on: https://chromium-review.googlesource.com/716876
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508748}
[modify] https://crrev.com/d1a7f3f12e7748e6eeed536703972f2f79f1570e/components/flags_ui/resources/flags.css
[modify] https://crrev.com/d1a7f3f12e7748e6eeed536703972f2f79f1570e/components/flags_ui/resources/flags.html
[modify] https://crrev.com/d1a7f3f12e7748e6eeed536703972f2f79f1570e/components/flags_ui/resources/flags.js

Esc leaves the search box, but doesn't clear the search. If you want to clear the search the delete button is a tab away.

Let me know how you get on.
Status: Fixed (was: Started)

Sign in to add a comment