Material chrome://flags: "Enabled" and "Disable" look very similar. |
||||
Issue descriptionChrome 63.0.3236.0 macOS 10.12.6 In Material chrome://flags, "Enabled" (tri-state) and "Disable" (boolean) look similar. This *sort of makes sense*, because they are both currently enabled. But the big blue box with a word in it takes a lot more attention than the checkmark, so it feels like the blue just draws attention, while "*En*abled" vs. "*Dis*able" gives a strong cue that these highlighted boxes currently represent opposite values. However, one represents your *current* setting, and one represents what you can change your setting *to*. I found the old version much clearer. The indication of which setting was enabled spans the entire column, and a tri-state setting dropdown was visually distinguishable from a button representing an *action*.
,
Oct 9 2017
,
Oct 9 2017
,
Oct 10 2017
+MaxWalker for design input. We may want to have a look at this styling again.
,
Oct 24 2017
Re: link vs. button. Links are used for navigation between views while buttons are used for actions. So I think we should use buttons for the enable and disable actions. Re: "enabled" vs. "enable" semantics. This has always been the case. We can't change <select>'s to describe an action. So I think the only way to make all descriptions semantically consistent would be to replace <button>'s with two-state <select>'s. However, <select>'s are slightly more cumbersome to use than <button>'s. Re: highlighting changed (non-default) experiments. I agree that the checkmark isn't quite clear in conjunction with a *disabled* flag. Since the filled (push and pull-down) buttons are quite visible on their own, I'd suggest to remove the checkmark indicators. I wouldn't say that the light-grey background was clear, I never even noticed it until very recently. :)
,
Oct 24 2017
FWIW I don't think that blue filled-in clearly or intuitievly marks "this setting has been changed from the default value", but it's elegant when you understand it.
,
Oct 27 2017
Chatted with Max and I'm going to replace the checkmark with a generic dot for the indicator in a CL shortly. I'm looking into switching all flag actions to selects so that all the states represent the current one. This is a bit more involved so will come later.
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd64a192d8b8a180fb40f389f4ecf8680467e968 commit dd64a192d8b8a180fb40f389f4ecf8680467e968 Author: Edward Jung <edwardjung@chromium.org> Date: Mon Oct 30 14:59:22 2017 chrome://flags UI tweaks + Hide the clear search button when there is no search entry. + Style improvements on iOS where Roboto is not loaded. + Switch the 'tick' indicator to a generic dot removing confusion as whether it indicates 'enabled'. Bug: 772782 , 772954 Change-Id: I26d208e45fdb64a0d8c922d377164f5a25a6d681 Reviewed-on: https://chromium-review.googlesource.com/735604 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#512494} [modify] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/components/flags_ui/resources/flags.css [modify] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/components/flags_ui/resources/flags.html
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0741d4fec343e6b1698df3e36fb35fefeab07fa commit d0741d4fec343e6b1698df3e36fb35fefeab07fa Author: Edward Jung <edwardjung@chromium.org> Date: Thu Nov 23 18:38:30 2017 chrome://flags convert enable/disable links into selection drop downs Currently there are two style of flags, 1. Those are either enabled / disabled represented as buttons that is labelled with the option to set it to. 2. Those with multiple options as drop down selections of the current option. This CL makes the flags of type 1 also use drop downs so all flags work in the same way showing the chosen option. Bug: 772954 Change-Id: I38e8334964233399a180ecc19bfc11f154d4f19c Reviewed-on: https://chromium-review.googlesource.com/783610 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#518991} [modify] https://crrev.com/d0741d4fec343e6b1698df3e36fb35fefeab07fa/components/flags_ui/resources/flags.css [modify] https://crrev.com/d0741d4fec343e6b1698df3e36fb35fefeab07fa/components/flags_ui/resources/flags.html [modify] https://crrev.com/d0741d4fec343e6b1698df3e36fb35fefeab07fa/components/flags_ui/resources/flags.js
,
Jan 30 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by meh...@chromium.org
, Oct 9 2017