New issue
Advanced search Search tips

Issue 772953 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Circles with radius under 5 are rendered imperfectly in print preview

Reported by cp...@alivecor.com, Oct 9 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce the problem:
1. Create svg circle with radius less than 5
2. Open file in chrome browser (see that the circle is a perfect circle)
3. Open print preview screen (see that the circle is an imperfect circle)

What is the expected behavior?
Circles should be perfect circle

What went wrong?
Viewing svg circles with radius less than 5 in print preview will yield an imperfect circle.

Did this work before? N/A 

Chrome version: 61.0.3163.100  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

- Circle.html is the source html file that renders 10 svg circles with radiuses from 1 to 10
- browserScreenPerfectCircles.png is a screenshot of chrome browser screen showing 10 perfect circles
- printScreenImperfectCircles.png is a screen shot of chrome's print preview screen showing 6 perfect circles and 4 imperfect circles

Chrome version - Version 61.0.3163.100 (Official Build) (64-bit)
Date: Oct 9 2017
OS Environment: macOS Sierra Version 10.12.6
 
circle.html
1.4 KB View Download
browserScreenPerfectCircles.png
102 KB View Download
printScreenImperfectCircles.png
100 KB View Download
Labels: Needs-Triage-M61
Components: -Blink Blink>SVG

Comment 3 by f...@opera.com, Oct 9 2017

Components: Internals>Skia>PDF
Status: Untriaged (was: Unconfirmed)
Conic weight issue when writing PDF?
Components: -Blink>SVG

Comment 5 by cp...@alivecor.com, Oct 18 2017

Hi Chromium Team,

Please let me know if there is anything I can do or provide to help your team solve this problem. 

Best,
Charles 

Comment 6 by cp...@alivecor.com, Nov 22 2017

Hi Chromium Team,

Following up on this issue, has there been any progress? If not, is there anything I can help provide to help solve this problem?

Best,
Charles
Owner: halcanary@chromium.org
Status: Started (was: Untriaged)
in progress: https://review.skia.org/75960
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/dfaa057c15180a18f65d86317618a97d683e99c4

commit dfaa057c15180a18f65d86317618a97d683e99c4
Author: Hal Canary <halcanary@google.com>
Date: Mon Nov 27 14:59:45 2017

SkPDF: less tolerance for small circles

BUG= chromium:772953 
Change-Id: I9452ac8ad66ab8be26a9388f8c85a1f0e61bd392
Reviewed-on: https://skia-review.googlesource.com/75960
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>

[modify] https://crrev.com/dfaa057c15180a18f65d86317618a97d683e99c4/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/dfaa057c15180a18f65d86317618a97d683e99c4/gn/gm.gni
[add] https://crrev.com/dfaa057c15180a18f65d86317618a97d683e99c4/gm/circle_sizes.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b13cefae31014390e4ec85f07528124106d925f

commit 3b13cefae31014390e4ec85f07528124106d925f
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Mon Nov 27 18:09:27 2017

Roll src/third_party/skia/ 4b0e364f9..dfaa057c1 (1 commit)

https://skia.googlesource.com/skia.git/+log/4b0e364f92a9..dfaa057c1518

$ git log 4b0e364f9..dfaa057c1 --date=short --no-merges --format='%ad %ae %s'
2017-11-27 halcanary SkPDF: less tolerance for small circles

Created with:
  roll-dep src/third_party/skia
BUG= 772953 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I731b91e62ce0546760658b9ed9fe21bb1ab8b405
Reviewed-on: https://chromium-review.googlesource.com/790630
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519337}
[modify] https://crrev.com/3b13cefae31014390e4ec85f07528124106d925f/DEPS

Status: Fixed (was: Started)

Sign in to add a comment