New issue
Advanced search Search tips

Issue 772946 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

With activation enabled with disable_ruleset_rules, we do not create the PageLoadStatistics object

Project Member Reported by shivanisha@chromium.org, Oct 9 2017

Issue description

If activation level is DISABLED, we do not create the PageLoadStatistics object.

one of the histograms (SubresourceFilter.PageLoad.BlockedPopups) is incorrectly coded to be dependent on the throttle manager being in ENABLED or DRYRUN. This should possibly be fixed with the abusive refactor.


 
Summary: With activation enabled with disable_ruleset_rules, we do not create the PageLoadStatistics object (was: If activation level is DISABLED, we do not create the PageLoadStatistics object )
Actually it's a bit more subtle, we need DRYRUN or ENABLED as well as a valid Async filter, which isn't created with disable_ruleset_rules.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/655b3cccf128cb8ee6f000a871ff0726b6134ca9

commit 655b3cccf128cb8ee6f000a871ff0726b6134ca9
Author: Charles Harrison <csharrison@chromium.org>
Date: Fri Oct 20 19:45:05 2017

[subresource_filter] Remove SubresourceFilter.PageLoad.BlockedPopups

This metric is broken, and we are moving to a new system for blocking
popups anyway.

The new metric will be landed here:
https://chromium-review.googlesource.com/c/chromium/src/+/726545

Bug:  772946 
Change-Id: Ib6ce9d316f7188be13a53988e06623ee93065df3
Reviewed-on: https://chromium-review.googlesource.com/728953
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510525}
[modify] https://crrev.com/655b3cccf128cb8ee6f000a871ff0726b6134ca9/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc
[modify] https://crrev.com/655b3cccf128cb8ee6f000a871ff0726b6134ca9/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/655b3cccf128cb8ee6f000a871ff0726b6134ca9/components/subresource_filter/content/browser/page_load_statistics.cc
[modify] https://crrev.com/655b3cccf128cb8ee6f000a871ff0726b6134ca9/components/subresource_filter/content/browser/page_load_statistics.h
[modify] https://crrev.com/655b3cccf128cb8ee6f000a871ff0726b6134ca9/tools/metrics/histograms/histograms.xml

Status: WontFix (was: Assigned)
WontFix (obsolete)

Sign in to add a comment