New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772941 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Many method names in canvas related code do not follow blink style

Project Member Reported by junov@chromium.org, Oct 9 2017

Issue description

Methods not using CamelCase:
CanvasRenderingContext::host
CanvasRenderingContext::color_params
CanvasRenderingContext::clearRect
CanvasColorParams::color_space
CanvasColorParams::pixel_format
ImageBuffer::size

etc.
 

Comment 1 by junov@chromium.org, Oct 9 2017

Components: Blink>Canvas
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3362a6c8242ada235c552a1f83943c69a97ae8aa

commit 3362a6c8242ada235c552a1f83943c69a97ae8aa
Author: Justin Novosad <junov@chromium.org>
Date: Tue Oct 10 15:48:51 2017

Standardize the names of some methods in canvas related code

Follow CamelCase naming convention and use the same name for methods
that do the same thing in different classes.

TBR=fserb@chromium.org

Bug:  772941 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9eaf9c9ced5404f4f9dfb9e28f11b0381eae8d61
Reviewed-on: https://chromium-review.googlesource.com/707200
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507676}
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedColorParams.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/platform/graphics/CanvasColorParams.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/platform/graphics/ImageBuffer.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
[modify] https://crrev.com/3362a6c8242ada235c552a1f83943c69a97ae8aa/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

Comment 3 by junov@chromium.org, Oct 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment