New issue
Advanced search Search tips

Issue 772917 link

Starred by 2 users
Status: Archived
Owner: ----
Closed: Mar 2018
Cc:
kathrelk...@chromium.org
achuith@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CL with Python syntax error made it through the CQ

Project Member Reported by jorgelo@chromium.org, Oct 9 2017 
https://chrome-internal-review.googlesource.com/c/472692/

Missing a colon after the function definition, still landed though. Should the CQ have caught this error?

Comment 1 by achuith@chromium.org, Oct 9 2017 

The actual CL has been fixed:
https://chrome-internal-review.googlesource.com/c/chromeos/autotest-cheets/+/473786

We don't seem to run verification scripts in the autotest-tests-cheets repo?

Comment 2 by jorgelo@chromium.org, Oct 9 2017 

Yeah saw the fix, but this was breaking the build, not breaking at runtime. If a regular build on my desk choked on this, the CQ should have choked as well, shouldn't it? At least the betty build maybe?

Comment 3 by akes...@chromium.org, Mar 31 2018

Status: Archived (was: Unconfirmed)
Bulk closing old unconfirmed issues.
►

Sign in to add a comment