New issue
Advanced search Search tips

Issue 772906 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 769761



Sign in to add a comment

Blacklist failing icalls and turn CFI-icall buildbot green

Project Member Reported by vtsyrklevich@chromium.org, Oct 9 2017

Issue description

Need to: split the CFI blacklist by CFI mode and add a wide icall blacklist to start working down.
 
Blockedon: 769761
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3168df0c78ea08f8b85d1b5a7d6829011c3d2b2

commit e3168df0c78ea08f8b85d1b5a7d6829011c3d2b2
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Wed Oct 18 00:07:16 2017

Split CFI blacklist by CFI mode

Group failing casts and vcalls separately. This ensures the release
build disables CFI checking as narrowly as possible--currently only
CFI-vcall is enabled for release but checking is also disabled for bad-
cast blacklist entries as well.

Bug:  772906 
Change-Id: Id8a91d1b01cbf858cf6be4f2b91fe548a521ef83
Reviewed-on: https://chromium-review.googlesource.com/706145
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509613}
[modify] https://crrev.com/e3168df0c78ea08f8b85d1b5a7d6829011c3d2b2/tools/cfi/blacklist.txt

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d8ae2fdc149b6bb42dfe30c1cb5b1d8dfe6a16a

commit 3d8ae2fdc149b6bb42dfe30c1cb5b1d8dfe6a16a
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Wed Oct 18 00:52:58 2017

Fix cfi-icall build by expanding the CFI blacklist

This adds a wide blacklist for failing cfi-icalls that will pass all
unit tests on Linux. This is functionally a to-do list of libraries and
routines that need to be fixed or refactored to work with cfi-icall.

Bug:  772906 
Change-Id: Ie483a818f95b594d799622b52a13086686522c25
Reviewed-on: https://chromium-review.googlesource.com/719733
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509633}
[modify] https://crrev.com/3d8ae2fdc149b6bb42dfe30c1cb5b1d8dfe6a16a/tools/cfi/blacklist.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbb0178df8a89a402e3c07852c8f8e5f3ad5ed5b

commit bbb0178df8a89a402e3c07852c8f8e5f3ad5ed5b
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Wed Oct 18 18:42:09 2017

Reland "Split CFI blacklist by CFI mode"

Group failing casts and vcalls separately. This ensures the release
build disables CFI checking as narrowly as possible--currently only
CFI-vcall is enabled for release but checking is also disabled for bad-
cast blacklist entries as well.

This time, place the 'internal_default_instance' entry under
[cfi-unrelated-cast].

Bug:  772906 
Change-Id: I185ce0244e890444913249d2560f3882b874ba5e
Reviewed-on: https://chromium-review.googlesource.com/726260
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509819}
[modify] https://crrev.com/bbb0178df8a89a402e3c07852c8f8e5f3ad5ed5b/tools/cfi/blacklist.txt

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49ac0394ed94ed21794cd8826b1c60186516ee43

commit 49ac0394ed94ed21794cd8826b1c60186516ee43
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Wed Oct 18 23:21:40 2017

Reland "Fix cfi-icall build by expanding the CFI blacklist"

This is a reland of 3d8ae2fdc149b6bb42dfe30c1cb5b1d8dfe6a16a
Original change's description:
> Fix cfi-icall build by expanding the CFI blacklist
> 
> This adds a wide blacklist for failing cfi-icalls that will pass all
> unit tests on Linux. This is functionally a to-do list of libraries and
> routines that need to be fixed or refactored to work with cfi-icall.
> 
> Bug:  772906 
> Change-Id: Ie483a818f95b594d799622b52a13086686522c25
> Reviewed-on: https://chromium-review.googlesource.com/719733
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509633}

Bug:  772906 
Change-Id: I17230612c6d690a55426eab3d4e691cd1fb7a298
Reviewed-on: https://chromium-review.googlesource.com/726543
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509918}
[modify] https://crrev.com/49ac0394ed94ed21794cd8826b1c60186516ee43/tools/cfi/blacklist.txt

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd7e1609639b1fc93adb59c42dd72e96b75ed407

commit cd7e1609639b1fc93adb59c42dd72e96b75ed407
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Thu Oct 19 21:56:15 2017

[cfi-icall] Blacklist NaCl

Blacklist the remaining icall buildbot failures in NaCl. I've avoided
categorizing the failures as NaCl is deprecated.

Bug:  772906 
Change-Id: I824a763bc86d64ab83c55774bcee03d24efb4376
Reviewed-on: https://chromium-review.googlesource.com/728304
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510226}
[modify] https://crrev.com/cd7e1609639b1fc93adb59c42dd72e96b75ed407/tools/cfi/blacklist.txt

Status: Fixed (was: Untriaged)
It's green now: https://build.chromium.org/p/chromium.clang/builders/CFI%20Linux%20%28icall%29
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16f822500eba838b624fb3dfff198359d343e531

commit 16f822500eba838b624fb3dfff198359d343e531
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Thu Nov 09 03:13:06 2017

[cfi-icall] Blacklist failing cross-DSO call

Add a blacklist entry for a newly failing icall.

Bug:  772906 
Change-Id: Ib424f3eb57d2b0184df69cdb34fccdcb0ae788c8
Reviewed-on: https://chromium-review.googlesource.com/759231
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515082}
[modify] https://crrev.com/16f822500eba838b624fb3dfff198359d343e531/tools/cfi/blacklist.txt

Sign in to add a comment