New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772904 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

add a metric to track CL wall-clock handling time

Project Member Reported by akes...@chromium.org, Oct 9 2017

Issue description

We currently track false rejections per CL, and handling time per CL that includes only the time during which a CL was submit-eligible (CR+2, V+1, CQ+1). The latter metric excludes the time between a when a CL is rejected by the CQ and when the developer re-marks it as CQ+1.

The CL exonerator project will potentially reduce false rejections significantly. But I wouldn't expect it to reduce handling time, because we're already not counting that rejected time towards handling time. The wall-clock time should be reduced by the exonerator though, since it will be re-marking CLs sooner than developers can manually.

I suggest the wall clock time be defined as: wall clock time between when the latest patchset of a CL first became submit-eligible, and when it was submitted.
 
That seems like a good metric. It's nice that it excludes any time a CL was in the CQ on a previous patchset, because it might have been revised to fix a CQ breakage.
Labels: -Pri-2 Pri-1
Owner: pho...@chromium.org
P1 as this is important baseline data for okr project.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/80016487c797f6e06a48bfa1075f64f57f64e253

commit 80016487c797f6e06a48bfa1075f64f57f64e253
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Oct 18 21:28:59 2017

clactions: Add CL wall clock time metric

Add a end-to-end CL patch wall clock time metric.

BUG= chromium:772904 
TEST=clactions_unittest

Change-Id: I02a1500d1a74180b59084afb70723e4d395b9108
Reviewed-on: https://chromium-review.googlesource.com/713581
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/80016487c797f6e06a48bfa1075f64f57f64e253/lib/constants.py
[modify] https://crrev.com/80016487c797f6e06a48bfa1075f64f57f64e253/lib/clactions.py

Status: Fixed (was: Available)
http://shortn/_BN826CA9Tn

Sign in to add a comment