New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772903 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

verity package shouldn't unconditionally compile tests

Project Member Reported by derat@chromium.org, Oct 9 2017

Issue description

chromeos-base/verity currently builds its tests (and depends on gmock and gtest) unconditionally. I think that this just happens because verity_testrunner is added to its "all" target.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dm-verity/+/0a59878032d4bda0c4a7c13b2086c59283df63f1

commit 0a59878032d4bda0c4a7c13b2086c59283df63f1
Author: Daniel Erat <derat@chromium.org>
Date: Tue Oct 10 19:19:06 2017

verity: Drop verity_testrunner from all target in Makefile.

Avoid compiling tests unconditionally.

Also replace msb@chromium.org with jorgelo@chromium.org in
OWNERS.

BUG= chromium:772903 
TEST=built it with and without FEATURES=test

Change-Id: Ic5d2c98053726f54e4ab4c65f4c0b9baccd17ee2
Reviewed-on: https://chromium-review.googlesource.com/707297
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0a59878032d4bda0c4a7c13b2086c59283df63f1/OWNERS
[modify] https://crrev.com/0a59878032d4bda0c4a7c13b2086c59283df63f1/Makefile

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e61a7792bbdefd0143acd0b008d3dc8d2f521d10

commit e61a7792bbdefd0143acd0b008d3dc8d2f521d10
Author: Daniel Erat <derat@chromium.org>
Date: Tue Oct 10 19:19:07 2017

verity: Remove unconditional gmock/gtest dependencies.

After tests are built by src_test instead of src_compile,
verity's gmock and gtest dependencies are only needed when
the test USE flag is set.

BUG= chromium:772903 
TEST=built it with and without FEATURES=test
CQ-DEPEND=Ic5d2c98053726f54e4ab4c65f4c0b9baccd17ee2

Change-Id: I4fed9514a99d991e588439b402d0e3d5a0f8abe6
Reviewed-on: https://chromium-review.googlesource.com/707299
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e61a7792bbdefd0143acd0b008d3dc8d2f521d10/chromeos-base/verity/verity-9999.ebuild

Comment 3 by derat@chromium.org, Oct 10 2017

Status: Verified (was: Started)

Sign in to add a comment