verity package shouldn't unconditionally compile tests |
||
Issue descriptionchromeos-base/verity currently builds its tests (and depends on gmock and gtest) unconditionally. I think that this just happens because verity_testrunner is added to its "all" target.
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e61a7792bbdefd0143acd0b008d3dc8d2f521d10 commit e61a7792bbdefd0143acd0b008d3dc8d2f521d10 Author: Daniel Erat <derat@chromium.org> Date: Tue Oct 10 19:19:07 2017 verity: Remove unconditional gmock/gtest dependencies. After tests are built by src_test instead of src_compile, verity's gmock and gtest dependencies are only needed when the test USE flag is set. BUG= chromium:772903 TEST=built it with and without FEATURES=test CQ-DEPEND=Ic5d2c98053726f54e4ab4c65f4c0b9baccd17ee2 Change-Id: I4fed9514a99d991e588439b402d0e3d5a0f8abe6 Reviewed-on: https://chromium-review.googlesource.com/707299 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e61a7792bbdefd0143acd0b008d3dc8d2f521d10/chromeos-base/verity/verity-9999.ebuild
,
Oct 10 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 10 2017