Save password dialog: vertical spacing between input rows too big |
||||
Issue descriptionChrome Version: 63.0.3236.0 OS: Windows, Mac What is the expected result? The margin between the input rows should be 12dp. Please see Bookmark dialog for comparison (chrome://flags/#secondary-ui-md enabled). What happens instead? The margin is 24dp. Thanks!
,
Oct 18 2017
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08d45cd1b978ffaa3b5a935876f7594312c7d372 commit 08d45cd1b978ffaa3b5a935876f7594312c7d372 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Wed Oct 18 10:45:41 2017 [Password Manager] Change the padding row between username and password in a prompt The CL re-uses the constant from bookmarks UI (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/harmony/textfield_layout.cc?rcl=4de610bbd16d98f5e1496eb68e96402214d0a0ec&l=86) Bug: 772893 Change-Id: Iae4969df9a5d022d98699e72645a09ad2653229b Reviewed-on: https://chromium-review.googlesource.com/725283 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#509736} [modify] https://crrev.com/08d45cd1b978ffaa3b5a935876f7594312c7d372/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Oct 20 2017
,
Oct 23 2017
Tested this issue on Mac 10.12.6, Windows 7 and Ubuntu 14.04 using chrome version 64.0.3247.0 as per the original comment. The margin between the input rows in the latest Chrome version is as attached in the screenshot. Please confirm if the fix is working as intended or no. Thanks..
,
Oct 23 2017
LGTM, thanks! The username and password fields still have a different height, however this is captured in 774530. |
||||
►
Sign in to add a comment |
||||
Comment 1 by vabr@chromium.org
, Oct 18 2017Labels: Hotlist-Polish M-63
Status: Assigned (was: Untriaged)