New issue
Advanced search Search tips

Issue 772888 link

Starred by 1 user
Status: Verified
Owner:
derat@chromium.org
Closed: Oct 2017
Cc:
benchan@chromium.org
vapier@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

gobi-cromo-plugin shouldn't depend unconditionally on gtest and gmock

Project Member Reported by derat@chromium.org, Oct 9 2017 
cros ~/trunk/src/scripts$ equery-lumpy d gmock                                                                                         
 * These packages depend on gmock:
...
chromeos-base/gobi-cromo-plugin-1.0.1-r2453 (dev-cpp/gmock

It looks like gobi-cromo-plugin unconditionally builds gobi_sdk_wrapper_unittest, gobi_handle_test, metrics_stopwatch_unittest, and gobi_modem_unittest.

There's more weirdness here, in that it also doesn't appear to run any of the unit tests when built with FEATURES=test, and inspects a custom "install_tests" USE flag to decide if it should actually install all four test files to the target image.

I'm just going to try to fix the dependencies right now, but someone who's more enthusiastic about Portage and gmake may want to go further. :-)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/142a33b5696b137e2d9e098fd6e33c4bfb810e99

commit 142a33b5696b137e2d9e098fd6e33c4bfb810e99
Author: Daniel Erat <derat@chromium.org>
Date: Thu Oct 19 19:56:44 2017

gobi-cromo-plugin: Drop unconditional gmock dep.

Update the gobi-cromo-plugin ebuild to only include gmock in
DEPEND when the test USE flag is set. Also update it to only
build the "tests" target when the USE flag is set.

BUG= chromium:772888 
TEST=built it with/without FEATURES=test and
     USE=install_tests
CQ-DEPEND=I132f3fda1abe3044bd9b5b757754809dbf19c967

Change-Id: I8115d6076219138978211fd233e34a73dc813780
Reviewed-on: https://chromium-review.googlesource.com/707180
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/142a33b5696b137e2d9e098fd6e33c4bfb810e99/chromeos-base/gobi-cromo-plugin/gobi-cromo-plugin-9999.ebuild
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c1b3dbce128c941686cb00719bf48488bfba5418

commit c1b3dbce128c941686cb00719bf48488bfba5418
Author: Daniel Erat <derat@chromium.org>
Date: Thu Oct 19 19:56:44 2017

gobi-cromo-plugin: Separate plugin and tests build targets.

Update gobi-cromo-plugin's Makefile to expose separate
targets for building the plugin and tests. This makes it
possible to stop building tests for non-test builds.

BUG= chromium:772888 
TEST=built it with/without FEATURES=test and
     USE=install_tests
CQ-DEPEND=I8115d6076219138978211fd233e34a73dc813780

Change-Id: I132f3fda1abe3044bd9b5b757754809dbf19c967
Reviewed-on: https://chromium-review.googlesource.com/707181
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c1b3dbce128c941686cb00719bf48488bfba5418/gobi-cromo-plugin/Makefile

Comment 3 by derat@chromium.org, Oct 19 2017

Status: Verified (was: Started)
►

Sign in to add a comment