Drop 'stable' version support in firmware update |
|||||
Issue descriptionOnce we have no more users we can drop support for the stable versions in: - Firmware update - master configuration binding (chromeos-config README.md) - cros-firmware.eclass Also need to check that no ebuilds define the variables Example CL for the firmware-update part here: https://chromium-review.googlesource.com/c/chromiumos/platform/firmware/+/594645
,
Oct 9 2017
My understanding is that this is implemented in a different way now: crbug.com/705414 go//cros-fw-update-2017
,
Oct 9 2017
As long was we can specify different RO and RW then I'm fine.
,
Oct 11 2017
The *STABLE* has been deprecated in last migration, although I don't understand why chromeos-firmware-mickey and chromeos-firmware-gandof are still having STABLE defined in -0.0.1-r99.ebuild (but we have already changed those in -9999.ebuild). I wonder if our portage has some problem dealing with -r99 and can't change the rev to r100. Add vapier@ to see if he has some thoughts. And I think you can't drop STABLE until vapier has figured out why mickey and gandof can't be automatically uprev'ed.
,
Oct 11 2017
cd overlay-gandof-private/chromeos-base/chromeos-firmware-gandof vim -d *.ebuild # you'll find what I meant in c#4.
,
Oct 11 2017
i don't know what you're referring to here. chromeos-firmware-mickey & chromeos-firmware-gandof have no diff between the 9999 & non-9999 (other than what should be, KEYWORDS & git sha1). $ grep STABLE * chromeos-firmware-gandof-0.0.1-r99.ebuild:CROS_FIRMWARE_STABLE_MAIN_VERSION="Google_Gandof.6301.155.9" chromeos-firmware-gandof-0.0.1-r99.ebuild:CROS_FIRMWARE_STABLE_EC_VERSION="gandof_v1.1.2328-2c846a3" chromeos-firmware-gandof-9999.ebuild:CROS_FIRMWARE_STABLE_MAIN_VERSION="Google_Gandof.6301.155.9" chromeos-firmware-gandof-9999.ebuild:CROS_FIRMWARE_STABLE_EC_VERSION="gandof_v1.1.2328-2c846a3" you'll have to be more specific as to what you think should be happening here. it looks correct to me.
,
Oct 12 2017
oh-no, I just realized I was looking at my local commit that was never uploaded... that explains why I'm seeing difference between -9999 and -r99. https://chrome-internal-review.googlesource.com/#/c/chromeos/overlays/overlay-gandof-private/+/477832/ https://chrome-internal-review.googlesource.com/#/c/chromeos/overlays/overlay-variant-veyron-mickey-private/+/477413/
,
Oct 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-gandof-private/+/4d56f2d931427d41c0ac7d50a424309246a755f0 commit 4d56f2d931427d41c0ac7d50a424309246a755f0 Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Oct 12 07:09:36 2017
,
Oct 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-variant-veyron-mickey-private/+/35cd5788ae4ccf177b8f5a5d02ba48118563672c commit 35cd5788ae4ccf177b8f5a5d02ba48118563672c Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Oct 12 07:09:35 2017
,
Oct 12 2017
ok, all firmware ebuilds with 'STABLE' are either removed or fixed. feel free to drop 'stable' from eclass, stub and packer scripts.
,
Nov 4 2017
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/c56deb788e99449034756f7c9c905159ce127d84 commit c56deb788e99449034756f7c9c905159ce127d84 Author: Simon Glass <sjg@chromium.org> Date: Mon Nov 13 01:44:30 2017 pack_firmware: Drop the stable firmware feature This is not used anywhere at present after a long migration effort by Hung-Te. Drop the code. BUG= chromium:772879 TEST=Run pack_firmware_functest.py and pack_firmware_unittest.py Change-Id: I333111e3d96083f3538701080336aef61a33cd46 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/759878 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/pack_dist/updater4.sh [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/test/chromeos-firmware-reef-9999.ebuild [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/unittests/crosutil_unittest [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/setvars_template [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/convert_to_model_unittest.py [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/pack_firmware_utils.py [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/pack_stub [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/convert_to_model.py [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/pack_firmware_functest.py [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/test/config_base.dtsi [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/pack_firmware.py [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/pack_dist/crosutil.sh [modify] https://crrev.com/c56deb788e99449034756f7c9c905159ce127d84/test/chromeos-firmware-reef-0.0.1-r56.ebuild
,
Nov 20 2017
This is done. There are still two references in autotest, but that work is underway.
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/c1a68889b4facf369f17ec80467044ad17b4a222 commit c1a68889b4facf369f17ec80467044ad17b4a222 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:02:09 2017 pack_firmware: Drop the stable firmware feature This is not used anywhere at present after a long migration effort by Hung-Te. Drop the code. BUG= chromium:772879 TEST=Run pack_firmware_functest.py and pack_firmware_unittest.py Change-Id: I333111e3d96083f3538701080336aef61a33cd46 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/759878 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/794603 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/pack_dist/updater4.sh [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/test/chromeos-firmware-reef-9999.ebuild [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/unittests/crosutil_unittest [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/setvars_template [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/convert_to_model_unittest.py [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/pack_firmware_utils.py [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/pack_stub [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/convert_to_model.py [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/pack_firmware_functest.py [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/test/config_base.dtsi [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/pack_firmware.py [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/pack_dist/crosutil.sh [modify] https://crrev.com/c1a68889b4facf369f17ec80467044ad17b4a222/test/chromeos-firmware-reef-0.0.1-r56.ebuild |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by adurbin@chromium.org
, Oct 9 2017