Unitless 0 angles should be supported for conic-gradient |
||
Issue descriptionUnitless 0 angle support is being deprecated in general, but we have legacy exceptions for gradients. Initially, the exception was not spec'ed for conic gradients, so we disabled the feature (https://codereview.chromium.org/2908053002). Now the spec verbiage has been updated to explicitly support unitless 0 angles, for consistency in gradient parsing: https://drafts.csswg.org/css-images-4/#conic-gradients "The unit identifier may be omitted if the <angle> is zero."
,
Oct 9 2017
Also note that while conic-gradient is not reflected in use counters because it is not enabled by default, there is content out there, supported by Lea's polyfill [1], which does make extensive use of unitless 0 angles. [1] https://leaverou.github.io/conic-gradient/
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6eb923a7dec772e787ab365e8e8cccfdf373ea77 commit 6eb923a7dec772e787ab365e8e8cccfdf373ea77 Author: Florin Malita <fmalita@chromium.org> Date: Tue Oct 10 12:26:10 2017 Re-enable unitless 0 angle support for conic-gradient The spec [1] has been updated to explicitly allow unitless 0 angles for conic-gradient, similar to linear-gradient. [1] https://drafts.csswg.org/css-images-4/#conic-gradients BUG= 772861 Change-Id: Ib2c8bffd324d577a9b1e7e77c4976a334d8d5cec Reviewed-on: https://chromium-review.googlesource.com/706933 Reviewed-by: Fredrik Söderquist <fs@opera.com> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#507645} [modify] https://crrev.com/6eb923a7dec772e787ab365e8e8cccfdf373ea77/third_party/WebKit/LayoutTests/fast/css/usecounter-angle-zero-gradient.html [modify] https://crrev.com/6eb923a7dec772e787ab365e8e8cccfdf373ea77/third_party/WebKit/LayoutTests/fast/gradients/conic-gradient-parsing.html [modify] https://crrev.com/6eb923a7dec772e787ab365e8e8cccfdf373ea77/third_party/WebKit/LayoutTests/fast/gradients/conic-gradient-positioning.html [modify] https://crrev.com/6eb923a7dec772e787ab365e8e8cccfdf373ea77/third_party/WebKit/LayoutTests/fast/gradients/conic-gradient.html [modify] https://crrev.com/6eb923a7dec772e787ab365e8e8cccfdf373ea77/third_party/WebKit/LayoutTests/fast/gradients/repeating-conic-gradient.html [modify] https://crrev.com/6eb923a7dec772e787ab365e8e8cccfdf373ea77/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
,
Oct 10 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by fmalita@chromium.org
, Oct 9 2017