ImageDocumentTest.ImageCenteredAtDeviceScaleFactor fails on Android |
||
Issue descriptionBot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29?numbuilds=200 Unfortunately, another issue caused this test to not run for many builds, so it's hard to find the offending CL using the build list. I'll do some digging. Last known good build: #70084 First known bad build: #70133
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0400d0014243549fb4fd84d6d4af1db3fc8fb252 commit 0400d0014243549fb4fd84d6d4af1db3fc8fb252 Author: Henrik Grunell <grunell@chromium.org> Date: Mon Oct 09 15:06:42 2017 Revert "Don't recenter image document when URL bar hides" This reverts commit a38acc8557b35c676bd5c936db0e1187bfa4ee57. Reason for revert: breaks Android bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29?numbuilds=200 http://crbug.com/772860 Original change's description: > Don't recenter image document when URL bar hides > > This patch changes the ImageDocument so that hiding the URL bar doesn't > attempt to vertically re-center an image that's wider than the viewport. > > Bug: 718515 > Change-Id: I0b45beb011c2c8dbc6f095a0456774f6f5e041ff > Reviewed-on: https://chromium-review.googlesource.com/700617 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507079} TBR=bokan@chromium.org,dtrainor@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 718515 , 772860 Change-Id: I5d82ae26c29068597bf90b29dbddcd9a46ba153d Reviewed-on: https://chromium-review.googlesource.com/707075 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#507376} [modify] https://crrev.com/0400d0014243549fb4fd84d6d4af1db3fc8fb252/third_party/WebKit/Source/core/html/ImageDocument.cpp [modify] https://crrev.com/0400d0014243549fb4fd84d6d4af1db3fc8fb252/third_party/WebKit/Source/core/html/ImageDocumentTest.cpp [modify] https://crrev.com/0400d0014243549fb4fd84d6d4af1db3fc8fb252/third_party/WebKit/Source/core/testing/sim/SimRequest.cpp [modify] https://crrev.com/0400d0014243549fb4fd84d6d4af1db3fc8fb252/third_party/WebKit/Source/core/testing/sim/SimRequest.h
,
Oct 10 2017
Sorry about that, I'll fix the test before relanding. I'll use issue 718515 to track that. |
||
►
Sign in to add a comment |
||
Comment 1 by grunell@chromium.org
, Oct 9 2017Status: Assigned (was: Untriaged)