New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772850 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Text and cursor is not seen after entering long text in text field on chrome://supervised-user-internals/ page

Reported by vineetha...@etouch.net, Oct 9 2017

Issue description

Chrome version: 63.0.3236.0 2fa96eead8c5eea003b5b7fb4f9262b3d136d76b-refs/heads/master@{#507286}(32/64 Bit)
OS: Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6).

Steps to reproduce:
1. Launch Chrome. Navigate to chrome://supervised-user-internals/.
2. Now type a long text in "Type a URL" text field and observe.

Actual Result: Text disappears and cursor is not seen after entering long text.
Expected Result: Text and cursor should be seen after entering long text.

This is Regression Issue broken in M-63 and will soon update other info,
Good Build: 63.0.3211.0
Bad Build: 63.0.3212.0


 
ActualResult.mp4
494 KB View Download
ExpectedResult.mp4
529 KB View Download
Summary: Regression: Text and cursor is not seen after entering long text in text field on chrome://supervised-user-internals/ page (was: Text and cursor is not seen after entering long text in text field on chrome://supervised-user-internals/ page)
Labels: hasbisect-per-revision
Owner: chrishtr@chromium.org
Status: Assigned (was: Unconfirmed)
This is Regression Issue broken in M-63 and using the per-revision bisect providing the bisect results,
Good Build: 63.0.3211.0((Revision: 500754)
Bad Build: 63.0.3212.0((Revision: 500792)

You are probably looking for a change made after 500791 (known good), but no later than 500792 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/d09b058a2fca054098e5bd14385516425766519b..c3a3481c4b1b08775b477144d1d2873a2a3d9900

Suspect: https://chromium.googlesource.com/chromium/src/+/c3a3481c4b1b08775b477144d1d2873a2a3d9900

@chrishtr : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.
M63 is branching soon, we will be taking only critical merges. It would be great to have a fix ASAP.
Reduced testcase attached.
test2.html
129 bytes View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/945b31d85a3f01f5bb59e9c52f244aa704f28e27

commit 945b31d85a3f01f5bb59e9c52f244aa704f28e27
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Sun Oct 15 07:08:56 2017

Compute a fragmented offset for control clips of input boxes.

Boxes without control clips don't necessarily have PaintLayers,
so in the current code are not necessarily fragmented. (*)
Such boxes should only end up in one fragment, because fragmenting
input elements or buttons doesn't make sense.

This patch computes the position of that fragment, and places
the control clip at that location.

(*) This is being changed in another much bigger patch, but
this bugfix is needed for M63.

Bug:  772850 
Change-Id: I187d3dcf9c0dea2b7703dd759bf8b5f2886d4e2e
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/720200
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508952}
[modify] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/LayoutTests/fast/multicol/input-with-overflow-second-column-expected.txt
[add] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/LayoutTests/fast/multicol/input-with-overflow-second-column.html
[add] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/LayoutTests/platform/linux/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/LayoutTests/platform/mac-retina/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/LayoutTests/platform/mac/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/LayoutTests/platform/win/fast/multicol/input-with-overflow-second-column-expected.png
[modify] https://crrev.com/945b31d85a3f01f5bb59e9c52f244aa704f28e27/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Labels: Merge-Request-63
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 16 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 16 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/800203ec582a0fb742a17f27157af1c345364cf1

commit 800203ec582a0fb742a17f27157af1c345364cf1
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Mon Oct 16 16:34:43 2017

Compute a fragmented offset for control clips of input boxes.

Boxes without control clips don't necessarily have PaintLayers,
so in the current code are not necessarily fragmented. (*)
Such boxes should only end up in one fragment, because fragmenting
input elements or buttons doesn't make sense.

This patch computes the position of that fragment, and places
the control clip at that location.

(*) This is being changed in another much bigger patch, but
this bugfix is needed for M63.

TBR=chrishtr@chromium.org

(cherry picked from commit 945b31d85a3f01f5bb59e9c52f244aa704f28e27)

Bug:  772850 
Change-Id: I187d3dcf9c0dea2b7703dd759bf8b5f2886d4e2e
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/720200
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508952}
Reviewed-on: https://chromium-review.googlesource.com/721759
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#11}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/LayoutTests/fast/multicol/input-with-overflow-second-column-expected.txt
[add] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/LayoutTests/fast/multicol/input-with-overflow-second-column.html
[add] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/LayoutTests/platform/linux/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/LayoutTests/platform/mac-retina/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/LayoutTests/platform/mac/fast/multicol/input-with-overflow-second-column-expected.png
[add] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/LayoutTests/platform/win/fast/multicol/input-with-overflow-second-column-expected.png
[modify] https://crrev.com/800203ec582a0fb742a17f27157af1c345364cf1/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment