Issue metadata
Sign in to add a comment
|
Regression: Dropdown is misaligned on expanding it on chrome://extensions.
Reported by
aiman.an...@etouch.net,
Oct 9 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3236.0 (Official Build)2fa96eead8c5eea003b5b7fb4f9262b3d136d76b-refs/heads/master@{#507286}(64-bit) OS: Mac(10.12.6, 10.13). Test URL: https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm?utm_source=chrome-ntp-icon Steps to reproduce: 1.Launch Chrome, go to the above link and add the above extension. 2.Go to chrome://extensions, click on ‘options’ for PDF Viewer extension. 3.On PDF Viewer extension overlay, click on any drop-down and observe. Actual Result: Drop-down is misaligned on expanding it. Expected Result: Drop-down should not be misaligned on expanding it. This is regression issue broken in ‘M-63’ and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good Build: 63.0.3223.0(Revision:503965) Bad Build: 63.0.3225.0(Revision:504540) You are probably looking for a change made after 504421 (known good), but no later than 504422 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1b62135c07abbd0fb531b03fddb3c2114cb06698..3131414035a033d1fb624913474dbdac04158198 Suspect: https://chromium.googlesource.com/chromium/src/+/3131414035a033d1fb624913474dbdac04158198 @lfg: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: The above issue is not seen on Linux and Windows OS. Thank You!
,
Oct 10 2017
M-63 will be branched in next few days, and would be good to have all the Beta blockers resolved before branch point. lfg@: Could you please update the thread and plan the fix or revert the CL if this is really a Beta blocker.
,
Oct 10 2017
M63 is branching on this Thursday (10/12) and M63 beta promotion is coming very soon. Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP. Thank you.
,
Oct 11 2017
Punting this to Stable blocker as the steps to repro requires extension to be added.
,
Oct 12 2017
Ehsan has a fix for this.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98b38fa0f40d63b09019f4536f6ccde70ed79797 commit 98b38fa0f40d63b09019f4536f6ccde70ed79797 Author: Ehsan Karamad <ekaramad@chromium.org> Date: Thu Oct 12 19:23:34 2017 Fix the position of page popups for OOPIF GuestViews on Mac This CL fixes a recent regressions in ExtensionsOptions pages where the popup was misplaced. The root cause was that BrowserPluginGuest::OnShowPopup does not transform the coordinates correctly for OOPIF guests. This regression was triggered after OOPIF-GuestViews went active by default. This CL fixes the issue by transforming the point to root coord space first. Bug: 772840 Change-Id: I87f314596e003e0eb74405f6be0018817745bf61 Reviewed-on: https://chromium-review.googlesource.com/714492 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#508377} [modify] https://crrev.com/98b38fa0f40d63b09019f4536f6ccde70ed79797/content/browser/browser_plugin/browser_plugin_guest.cc
,
Oct 12 2017
Adding the right labels and request for merge into M62 (and potentially M63 depending on whether or not the fix made it to 63 cut).
,
Oct 12 2017
This bug requires manual review: We don't branch M63 until 2017-10-12. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 12 2017
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 12 2017
I was able to successfully recreate this issue in M61. How safe/complex is this fix overall? Has it been well tested in Canary?
,
Oct 13 2017
Note: Retested the above issue on latest Canary #63.0.3239.0 on Mac(10.12.6) and fix is working as intended.
,
Oct 13 2017
,
Oct 13 2017
I believe the fix is safe and do not expect it to cause any stability issues. lfg@ WDYT? On one hand this fixes a user facing bug which I believe occurs frequently. On the other hand it has existed since 61.
,
Oct 13 2017
Re #13: Yes, I think this is small enough that should be fine to merge, but it's not a huge deal if we don't end up merging, as the drop downs still work, even though they aren't correctly placed.
,
Oct 13 2017
Since fix has been verified and it's a quite small fix, for an issue that is impacting users frequentyly, I'm fine approving this merge for M62. Branch:3202.
,
Oct 13 2017
CL listed at #6 is already in M63 branch (3239) at chromium revision 508578.So no M63 merge is needed.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4ea8abec529f97bdc6ec79352c76df0aada1e69 commit e4ea8abec529f97bdc6ec79352c76df0aada1e69 Author: Ehsan Karamad <ekaramad@chromium.org> Date: Fri Oct 13 22:10:13 2017 Fix the position of page popups for OOPIF GuestViews on Mac This CL fixes a recent regressions in ExtensionsOptions pages where the popup was misplaced. The root cause was that BrowserPluginGuest::OnShowPopup does not transform the coordinates correctly for OOPIF guests. This regression was triggered after OOPIF-GuestViews went active by default. This CL fixes the issue by transforming the point to root coord space first. Bug: 772840 TBR=ekaramad@chromium.org (cherry picked from commit 98b38fa0f40d63b09019f4536f6ccde70ed79797) Change-Id: I87f314596e003e0eb74405f6be0018817745bf61 Reviewed-on: https://chromium-review.googlesource.com/714492 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508377} Reviewed-on: https://chromium-review.googlesource.com/719959 Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#684} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/e4ea8abec529f97bdc6ec79352c76df0aada1e69/content/browser/browser_plugin/browser_plugin_guest.cc
,
Oct 17 2017
Note: Retested the above issue on Mac(10.12.6) using Stable #62.0.3202.62 and fix is working as intended.
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Oct 9 2017