Regression: 'Never Saved' label overlaps with 'Password deleted UNDO' toast notification in chrome://settings/passwords
Reported by
nutan.ga...@etouch.net,
Oct 9 2017
|
|||||||
Issue descriptionChrome Version: 63.0.3236.0 2fa96eead8c5eea003b5b7fb4f9262b3d136d76b-refs/heads/master@{#507286} OS: Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6). Pre-condition: Save any password in Password manager Steps to reproduce: 1. Launch chrome, navigate to chrome://settings/passwords 2. Resize the browser window till 'Never Saved' label and click on 'More action' icon of 'Saved Passwords' 3. Click on 'Remove' and observe the 'Never Saved' label and 'Password deleted UNDO' toast notification Actual: 'Never Saved' label overlaps with 'Password deleted UNDO' toast notification Expected: 'Never Saved' label should not overlap with the 'Password deleted UNDO' toast notification This is regression issue broken in 'M-63' and will soon update bisect info. Good build:63.0.3232.0 Bad build:63.0.3233.0 You are probably looking for a change made after 506275 (known good), but no later than 506276 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/8014051d3682961c3b79a6cace11d7351bdd279f..3c9b6980e8778a7434e5ec131287e9dcfc771833 Suspect: https://chromium.googlesource.com/chromium/src/+/3c9b6980e8778a7434e5ec131287e9dcfc771833
,
Oct 9 2017
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6911b9014208f3ba11232d2e13134b4f289d6bd commit e6911b9014208f3ba11232d2e13134b4f289d6bd Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Oct 11 18:39:03 2017 [MD settings] move cr-toast to appear over other elements This CL moves the cr-toast element later in the dom so that it is drawn over other elements. Bug: 772825 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibfd5ff9d7d5593589b547b7bc0b4d49396a0e311 Reviewed-on: https://chromium-review.googlesource.com/707814 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#508046} [modify] https://crrev.com/e6911b9014208f3ba11232d2e13134b4f289d6bd/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
,
Oct 11 2017
,
Oct 12 2017
Retested the above issue on latest Canary(PGO) #63.0.3238.0 on Win(7,8,10) and Linux(!4.04 LTS) and fix is working as intended. Kindly refer the attached video
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dschuyler@chromium.org
, Oct 9 2017