New issue
Advanced search Search tips

Issue 772824 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

css classes suggestbox (cls) doesn't sort suggestions

Reported by eng.a7ma...@gmail.com, Oct 9 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce the problem:
1. open https://codepen.io/a7madgamal-1477000865/pen/OxvEBb
2. inspect a1
3. click 'cls' button and type the letter a to trigger the auto suggestion box

What is the expected behavior?
I expect the suggestions to be sorted alphabetically
a (since it exists and it fully match what I wrote so far!)
a-1
a-2
and so on

What went wrong?
the order is completely random!
and even worse the selected class (which is applied) is not the one I wrote so far although a class exists with that entry, I have to write a space to get the one I need

Did this work before? N/A 

Chrome version: 61.0.3163.100  Channel: stable
OS Version: OS X 10.13.0
Flash Version: 

It's really important when you have to work with some css framework who append strings to class names for responsive break points etc
 

Comment 1 by alph@chromium.org, Oct 9 2017

Labels: -Pri-2 Pri-3
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Eric, can you please take a look.
Labels: M-63
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/909184486c569431ec2fdbed8083730159497b05

commit 909184486c569431ec2fdbed8083730159497b05
Author: Erik Luo <luoe@chromium.org>
Date: Thu Nov 09 02:59:14 2017

DevTools: classes pane widget should show inactive classnames sorted

In Elements panel, the ClassesPaneWidget's autocomplete
- now shows sorted suggestions
- will not suggest classnames that are already applied

Bug:  772824 
Change-Id: I344e14c8e5edbb0c592ae44599725eb08a7d298a
Reviewed-on: https://chromium-review.googlesource.com/747275
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515076}
[add] https://crrev.com/909184486c569431ec2fdbed8083730159497b05/third_party/WebKit/LayoutTests/http/tests/devtools/elements/classes-pane-widget-expected.txt
[add] https://crrev.com/909184486c569431ec2fdbed8083730159497b05/third_party/WebKit/LayoutTests/http/tests/devtools/elements/classes-pane-widget.js
[modify] https://crrev.com/909184486c569431ec2fdbed8083730159497b05/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

Comment 4 by l...@chromium.org, Nov 9 2017

Status: Fixed (was: Assigned)
THANKS!! 🤘🏻

Sign in to add a comment