New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 772815 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The zip::Zip() API should abstract file access operations.

Project Member Reported by jcivelli@chromium.org, Oct 9 2017 
The zip::Zip() API should abstract file access operations instead of reading files directly from disk, so that it can be run in a sandboxed process that can only read file though Mojo calls.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91ac47fceb859a3804b38ec4f3befcef0f29b019

commit 91ac47fceb859a3804b38ec4f3befcef0f29b019
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Oct 12 02:38:53 2017

Abstrating file access operation in zip creation.

Abstracting file access operations when creating ZIP files. This is
going to be useful when ZIP operations are done by a Mojo service in a
sandboxed environment and can only access files through IPC.

In order to make the API cleaner, introduced a parameter class that
lets caller specify which options to use.

Bug:  772815 
Change-Id: I229291a0c37bfee8fd29fe894a8118c91afab074
Reviewed-on: https://chromium-review.googlesource.com/706282
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508233}
[modify] https://crrev.com/91ac47fceb859a3804b38ec4f3befcef0f29b019/third_party/zlib/google/zip.cc
[modify] https://crrev.com/91ac47fceb859a3804b38ec4f3befcef0f29b019/third_party/zlib/google/zip.h
[modify] https://crrev.com/91ac47fceb859a3804b38ec4f3befcef0f29b019/third_party/zlib/google/zip_internal.cc
[modify] https://crrev.com/91ac47fceb859a3804b38ec4f3befcef0f29b019/third_party/zlib/google/zip_internal.h
[modify] https://crrev.com/91ac47fceb859a3804b38ec4f3befcef0f29b019/third_party/zlib/google/zip_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b092fa9950a914b79d01ad59e6ec3f9c8e18b0db

commit b092fa9950a914b79d01ad59e6ec3f9c8e18b0db
Author: Keishi Hattori <keishi@chromium.org>
Date: Thu Oct 12 05:00:26 2017

Revert "Abstrating file access operation in zip creation."

This reverts commit 91ac47fceb859a3804b38ec4f3befcef0f29b019.

Reason for revert: Failing unit_tests ZipTest.UnzipUncompressed and others

 crbug.com/773963 

Original change's description:
> Abstrating file access operation in zip creation.
> 
> Abstracting file access operations when creating ZIP files. This is
> going to be useful when ZIP operations are done by a Mojo service in a
> sandboxed environment and can only access files through IPC.
> 
> In order to make the API cleaner, introduced a parameter class that
> lets caller specify which options to use.
> 
> Bug:  772815 
> Change-Id: I229291a0c37bfee8fd29fe894a8118c91afab074
> Reviewed-on: https://chromium-review.googlesource.com/706282
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Chris Blume <cblume@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508233}

TBR=jcivelli@chromium.org,isherman@chromium.org,satorux@chromium.org,cblume@chromium.org

Change-Id: I91fb4aa3b5920eac88e1ba6900a441961117c632
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  772815 
Reviewed-on: https://chromium-review.googlesource.com/715036
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508256}
[modify] https://crrev.com/b092fa9950a914b79d01ad59e6ec3f9c8e18b0db/third_party/zlib/google/zip.cc
[modify] https://crrev.com/b092fa9950a914b79d01ad59e6ec3f9c8e18b0db/third_party/zlib/google/zip.h
[modify] https://crrev.com/b092fa9950a914b79d01ad59e6ec3f9c8e18b0db/third_party/zlib/google/zip_internal.cc
[modify] https://crrev.com/b092fa9950a914b79d01ad59e6ec3f9c8e18b0db/third_party/zlib/google/zip_internal.h
[modify] https://crrev.com/b092fa9950a914b79d01ad59e6ec3f9c8e18b0db/third_party/zlib/google/zip_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/513d84a6fa9942743df99c46c33ea5c863a220d4

commit 513d84a6fa9942743df99c46c33ea5c863a220d4
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Oct 12 23:35:18 2017

Relanding "Abstrating file access operation in zip creation."

Disabled the added conditions that caused the tests to fail (only on the
build bots) and added logs for investigation.

Bug:  772815 
Tbr: isherman
Change-Id: I1f20bfe40288b6822397d469863deb643a93b17d
Reviewed-on: https://chromium-review.googlesource.com/716597
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508539}
[modify] https://crrev.com/513d84a6fa9942743df99c46c33ea5c863a220d4/third_party/zlib/google/zip.cc
[modify] https://crrev.com/513d84a6fa9942743df99c46c33ea5c863a220d4/third_party/zlib/google/zip.h
[modify] https://crrev.com/513d84a6fa9942743df99c46c33ea5c863a220d4/third_party/zlib/google/zip_internal.cc
[modify] https://crrev.com/513d84a6fa9942743df99c46c33ea5c863a220d4/third_party/zlib/google/zip_internal.h
[modify] https://crrev.com/513d84a6fa9942743df99c46c33ea5c863a220d4/third_party/zlib/google/zip_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adb61db19020ed8ecee5e91b1a0ea4c924ae2988

commit adb61db19020ed8ecee5e91b1a0ea4c924ae2988
Author: Jay Civelli <jcivelli@chromium.org>
Date: Fri Oct 13 01:13:22 2017

Revert "Relanding "Abstrating file access operation in zip creation.""

This reverts commit 513d84a6fa9942743df99c46c33ea5c863a220d4.

Reason for revert: it breaks the unit-tests.

Original change's description:
> Relanding "Abstrating file access operation in zip creation."
> 
> Disabled the added conditions that caused the tests to fail (only on the
> build bots) and added logs for investigation.
> 
> Bug:  772815 
> Tbr: isherman
> Change-Id: I1f20bfe40288b6822397d469863deb643a93b17d
> Reviewed-on: https://chromium-review.googlesource.com/716597
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508539}

TBR=jcivelli@chromium.org,isherman@chromium.org

Change-Id: Ife1a2ebe47b29b4231125aef4058c489d254baf4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  772815 
Reviewed-on: https://chromium-review.googlesource.com/717737
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508578}
[modify] https://crrev.com/adb61db19020ed8ecee5e91b1a0ea4c924ae2988/third_party/zlib/google/zip.cc
[modify] https://crrev.com/adb61db19020ed8ecee5e91b1a0ea4c924ae2988/third_party/zlib/google/zip.h
[modify] https://crrev.com/adb61db19020ed8ecee5e91b1a0ea4c924ae2988/third_party/zlib/google/zip_internal.cc
[modify] https://crrev.com/adb61db19020ed8ecee5e91b1a0ea4c924ae2988/third_party/zlib/google/zip_internal.h
[modify] https://crrev.com/adb61db19020ed8ecee5e91b1a0ea4c924ae2988/third_party/zlib/google/zip_unittest.cc

Comment 6 by jcivelli@chromium.org, Nov 7 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment