New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772814 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-15
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Android WebView] Lower minidump crash reporting fraction in time for 63 Stable.

Project Member Reported by gsennton@chromium.org, Oct 9 2017

Issue description

We did this for 62 in  crbug.com/758916   

for that release we used 1% as the fraction - we should do so for 63 as well.
 

Comment 1 by cma...@chromium.org, Oct 12 2017

Labels: ReleaseBlock-Stable M-63
gsennton@,

You are going to merge this change to M63 just couple weeks before M63 stable, right?

Thanks!
Yepp, well we won't merge it - we will just land it directly on the M63 branch (we never land this on stable).
The NextAction date has arrived: 2017-11-15
Estelle, when should we land this change to make sure it's in before the creating the beta which will be used as stable for 63?

Comment 6 by cma...@chromium.org, Nov 20 2017

The last M63 beta build prior to stable release will be next week wednesday so land this CL next week Monday Nov 27th so it can included it that build. 

It is not certain that the last beta build will be the same that goes to stable. It will most likely not be the case so if you want to land this CL for the stable build only, you need to land it on Monday morning December 4th.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 27 2017

Labels: merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3a3196c4ebf33db5b2cb2ff9c14d6d4988827aa

commit c3a3196c4ebf33db5b2cb2ff9c14d6d4988827aa
Author: Gustav Sennton <gsennton@google.com>
Date: Mon Nov 27 11:51:58 2017

[Android WebView] Lower minidump generation fraction to 1% for Stable

To avoid hitting the cap on the number of uploaded crash reports per day
we lower the fraction of uploaded reports from 100% for Beta to 1% for
Stable.
Note that there should be at least one Beta version with the new lowered
fraction since we do not want to re-push Beta just for this change.

BUG= 772814 

Change-Id: I0542225dc89f453b726db29932eee75b6e5be668
Reviewed-on: https://chromium-review.googlesource.com/786233
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#570}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/c3a3196c4ebf33db5b2cb2ff9c14d6d4988827aa/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified  on Pixel 2/OPM1.171019.011 having 63.0.3239.71 with the flags generates Mini dump crash ID .
gsennton@ please create this for M64.
Done:  crbug.com/791527 
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 15 2018

Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7722206d01e517903f04befb240cbfbbb412f76c

commit 7722206d01e517903f04befb240cbfbbb412f76c
Author: Gustav Sennton <gsennton@google.com>
Date: Mon Jan 15 11:44:15 2018

[Android WebView] Lower minidump generation fraction to 1% for Stable

To avoid hitting the cap on the number of uploaded crash reports per day
we lower the fraction of uploaded reports from 100% for Beta to 1% for
Stable.
Note that there should be at least one Beta version with the new lowered
fraction since we do not want to re-push Beta just for this change.

BUG= 772814 

Change-Id: I65607713e2ac2b3d3205505960b2b74444de089d
Reviewed-on: https://chromium-review.googlesource.com/860142
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#503}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/7722206d01e517903f04befb240cbfbbb412f76c/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc

Woops, that CL was supposed to target  crbug.com/791527  >.<

Sign in to add a comment