New issue
Advanced search Search tips

Issue 772811 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Nov 30
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

blink_test_controller does not wait for resize to complete before running a test

Project Member Reported by atotic@chromium.org, Oct 9 2017 
https://cs.chromium.org/chromium/src/content/shell/browser/layout_test/blink_test_controller.cc?rcl=515d633f32b380efe7b5f609472e6e1891bb0c57&l=416

BlinkTestController::PrepareForLayoutTest does not wait for shell resize to complete.

This causes occational failures if SVG-1.1 tests (which require size of 640x320) and regular tests (sized 800x600) are mixed together.

To demonstrate the bug, run SVG-1.1 and regular tests fully parallel:

python third_party/WebKit/Tools/Scripts/run-webkit-tests svg external/wpt/css/CSS2/positioning -f

~100/3000 tests will fail because window size was incorrect.

I've tried fixing this but my knowledge of resize code flow is non-existent. One thing I've noticed is that in all the failing tests RenderWidgetHostImpl::NotifyScreenInfoChanged gets called after the test was already started.

I've also tried using browser_test_utils::WaitForResizeComplete and it did not help.

This bug is best handled by someone who has good understanding of interaction between host and view.

Comment 1 by kereliuk@chromium.org, Nov 29 2017

Status: Available (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 30

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by atotic@chromium.org, Nov 30

Status: WontFix (was: Untriaged)
I fixed all the svg tests, so this is no longer as interesting.
►

Sign in to add a comment