desktop-pwas: Bounce back out-of-scope navigations to the browser |
||||
Issue descriptionRather than navigating to a third party website that probably has no way to get back to the original app, we bounce back to an existing browser window. This is probably temporary until we add something similar to Chrome Custom Tabs for desktop.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/199f50c2acf6945c1e41d1a17bdf467baee7f8a2 commit 199f50c2acf6945c1e41d1a17bdf467baee7f8a2 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Fri Nov 10 06:14:15 2017 desktop-pwas: Bounce out-of-scope navigations back to the browser Rather than navigating to a third party website that probably has no way to get back to the original app, we bounce back to an existing browser window. Bug: 772803 Change-Id: Ie662bfa59e920d059ade3cc06d77664732ab31fe Reviewed-on: https://chromium-review.googlesource.com/706882 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#515460} [modify] https://crrev.com/199f50c2acf6945c1e41d1a17bdf467baee7f8a2/chrome/browser/extensions/bookmark_app_navigation_throttle.cc [modify] https://crrev.com/199f50c2acf6945c1e41d1a17bdf467baee7f8a2/chrome/browser/extensions/bookmark_app_navigation_throttle.h [modify] https://crrev.com/199f50c2acf6945c1e41d1a17bdf467baee7f8a2/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
,
Nov 21 2017
,
Nov 21 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5945e06e67202c583eb496a54bd5f8f162b9760 commit d5945e06e67202c583eb496a54bd5f8f162b9760 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Nov 30 06:52:43 2017 desktop-pwas: When in an app, bounce out of scope form submissions to a new tab Before, BookmarkAppNavigationThrottle would ignore all form submissions. Now, it redirects out-of-scope form submissions inside an app window to a new browser tab. OpenApplication doesn't support post requests yet, so in-scope post requests in a regular browser tab for now remain in the tab. Bug: 772803 Change-Id: Iea785701ed74cb02664bc90b6ea079e40e9df708 Reviewed-on: https://chromium-review.googlesource.com/781309 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#520464} [modify] https://crrev.com/d5945e06e67202c583eb496a54bd5f8f162b9760/chrome/browser/extensions/bookmark_app_navigation_throttle.cc [modify] https://crrev.com/d5945e06e67202c583eb496a54bd5f8f162b9760/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc [modify] https://crrev.com/d5945e06e67202c583eb496a54bd5f8f162b9760/content/browser/frame_host/navigation_handle_impl.cc [modify] https://crrev.com/d5945e06e67202c583eb496a54bd5f8f162b9760/content/browser/frame_host/navigation_handle_impl.h [modify] https://crrev.com/d5945e06e67202c583eb496a54bd5f8f162b9760/content/browser/frame_host/render_frame_host_manager.cc [modify] https://crrev.com/d5945e06e67202c583eb496a54bd5f8f162b9760/content/public/browser/navigation_handle.h [modify] https://crrev.com/d5945e06e67202c583eb496a54bd5f8f162b9760/content/public/test/test_navigation_observer.cc [modify] https://crrev.com/d5945e06e67202c583eb496a54bd5f8f162b9760/content/public/test/test_navigation_observer.h
,
Nov 30 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ortuno@chromium.org
, Oct 9 2017Components: UI>Browser>WebAppInstalls
Labels: -Type-Bug OS-Chrome OS-Linux OS-Mac OS-Windows Type-Feature