New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 772799 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Oct 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Extra padding is observed in permission bubble.

Reported by avsha...@etouch.net, Oct 9 2017 
Chrome version : 63.0.3236.0 (Official Build) 2fa96eead8c5eea003b5b7fb4f9262b3d136d76b-refs/heads/master@{#507286} 32/64 bit
OS : Windows (7,8,10), Linux(14.04 LTS)

Test URL : https://permission.site/

What steps will reproduce the problem?
1. Launch chrome, navigate to above test URL, click on 'Auto Download' button seen on the page and click on 'Block' in permission bubble.
2. Click on blocked 'Auto Download' icon seen at the RHS of omnibox and observe the bubble.

Actual Result : Extra padding is observed between bubble header and body.

Expected Result : Padding between bubble header and body should be proper.

This is a regression issue broken in ‘M-63’, below is the manual bisect range and will soon update other info.
Good build : 63.0.3232.0
Bad build : 63.0.3233.0
Actual_Result.mp4
607 KB View Download
Bubble_Padding.png
22.3 KB View Download

Comment 1 by avsha...@etouch.net, Oct 9 2017

Labels: hasbisect-per-revision
Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build : 63.0.3232.0 (Revision : 506257)
Bad build : 63.0.3233.0 (Revision : 506599)

You are probably looking for a change made after 506543 (known good), but no later than 506544 (first known bad).

CHANGELOG URL: 
https://chromium.googlesource.com/chromium/src/+log/54d8a4152bedbb9d29c425f4c93dbde307856235..f18dc4824eee4d272ea02011652d4c887f468300

Suspect : https://chromium.googlesource.com/chromium/src/+/f18dc4824eee4d272ea02011652d4c887f468300

@ellyjones : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : Above issue is not observed on Mac(10.12.6) OS.

Thank you!

Comment 2 by ranjitkan@chromium.org, Oct 9 2017

Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.

Comment 3 by ellyjo...@chromium.org, Oct 10 2017 

Hm, this is the pre-Harmony bubble. I'll take a look.

Comment 4 by ellyjo...@chromium.org, Oct 10 2017

Status: Started (was: Assigned)
Here are before & after screenshots for <https://chromium-review.googlesource.com/c/chromium/src/+/709255>.
Screen Shot 2017-10-10 at 11.15.48 AM.png
51.9 KB View Download
Screen Shot 2017-10-10 at 11.17.15 AM.png
51.4 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/534bebdd3407d6c078beb8f37270fb237fe06c00

commit 534bebdd3407d6c078beb8f37270fb237fe06c00
Author: Elly Fong-Jones <ellyjones@google.com>
Date: Wed Oct 11 13:43:32 2017

views: don't use padding pre-Harmony either

This padding was already removed for Harmony dialogs by
<https://chromium-review.googlesource.com/c/chromium/src/+/700400>, but it seems
unnecessary in pre-Harmony dialogs either - see the screenshots on the bug for
an example.

Bug:  772799 
Change-Id: I1af53f1cdb4f5eed52847689c58234c081db8898
Reviewed-on: https://chromium-review.googlesource.com/709255
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507968}
[modify] https://crrev.com/534bebdd3407d6c078beb8f37270fb237fe06c00/chrome/browser/ui/views/content_setting_bubble_contents.cc

Comment 6 by ellyjo...@chromium.org, Oct 11 2017

Status: Fixed (was: Started)

Comment 7 by avsha...@etouch.net, Oct 12 2017

Labels: TE-Verified-M63 TE-Verified-63.0.3238.0
Update : 
Retested above issue in latest chrome canary #63.0.3238.0 build on Windows(7,8,10), Linux (14.04 LTS) OS and issue is fixed. Now no extra padding is seen in blocked permission bubble.
Kindly review an attached screen cast.

Thank you!
Canary_Behavior.mp4
539 KB View Download
►

Sign in to add a comment