New issue
Advanced search Search tips

Issue 772793 link

Starred by 2 users
Status: Fixed
Owner:
leon....@intel.com
Closed: Mar 2018
Cc:
falken@chromium.org
kinuko@chromium.org
leon....@intel.com
shimazu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 782528
Blocking:
issue 629701
issue 783071



Sign in to add a comment

Impl mojo interface ServiceWorkerHost

Project Member Reported by leon....@intel.com, Oct 9 2017 
This is to mojofy IPCs sent from a SW instance running in the renderer process to the corresponding SWVersion instance in the browser process.

Put into third_party/WebKit/public/platform/modules/serviceworker/service_worker.mojom:

'
interface ServiceWorkerHost {
  GetClient();
  GetClients();
  OpenNewTab();
  OpenNewPopup();
  SetCachedMetadata();
  ClearCachedMetadata();
  PostMessageToClient();
  FocusClient();
  NavigateClient();
  SkipWaiting();
  ClaimClients();
};
'

To mojofy these legacy IPCs:
  ServiceWorkerHostMsg_GetClient
  ServiceWorkerHostMsg_GetClients
  ServiceWorkerHostMsg_OpenNewTab
  ServiceWorkerHostMsg_OpenNewPopup
  ServiceWorkerHostMsg_SetCachedMetadata
  ServiceWorkerHostMsg_ClearCachedMetadata
  ServiceWorkerHostMsg_PostMessageToClient
  ServiceWorkerHostMsg_FocusClient
  ServiceWorkerHostMsg_NavigateClient
  ServiceWorkerHostMsg_SkipWaiting
  ServiceWorkerHostMsg_ClaimClients

Comment 1 by xiaofeng...@intel.com, Nov 3 2017 

One more is EmbeddedWorkerHostMsg_CountFeature, it seems we also need to implement here?

Comment 2 by leon....@intel.com, Nov 3 2017 

Yeah, I think so.

Comment 3 by leon....@intel.com, Nov 8 2017

Blockedon: 782528
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7e56501d04a08af214751039d8fe0f96d241310

commit f7e56501d04a08af214751039d8fe0f96d241310
Author: Han Leon <leon.han@intel.com>
Date: Wed Nov 08 05:47:57 2017

[ServiceWorker] A cleanup for ServiceWorkerVersion

This CL removes some redundant/useless code.

BUG= 772793 

Change-Id: I43e70d70b43e05a396fca1e4d37088f4d2c3cc29
Reviewed-on: https://chromium-review.googlesource.com/757984
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#514766}
[modify] https://crrev.com/f7e56501d04a08af214751039d8fe0f96d241310/content/browser/service_worker/service_worker_version.h

Comment 5 by leon....@intel.com, Nov 9 2017

Blocking: 783071
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d1582378605772c870e7d5431f5f7c53c87b9cb

commit 2d1582378605772c870e7d5431f5f7c53c87b9cb
Author: Han Leon <leon.han@intel.com>
Date: Tue Nov 14 11:04:33 2017

[ServiceWorker] Introduce ServiceWorkerHost interface

BUG= 772793 

Change-Id: I48b56e1da07429a4630c6ba7bc7625c13e85a252
Reviewed-on: https://chromium-review.googlesource.com/758154
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#516261}
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/DEPS
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_script_cache_map.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_script_cache_map.h
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/2d1582378605772c870e7d5431f5f7c53c87b9cb/third_party/WebKit/public/platform/modules/serviceworker/service_worker.mojom

Comment 7 by leon....@intel.com, Nov 15 2017

Cc: -xiaofeng...@intel.com leon....@intel.com
Owner: xiaofeng...@intel.com
Status: Assigned (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5

commit c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Tue Dec 12 11:25:52 2017

[ServiceWorker] Implement ServiceWorkerHost.ClaimClients

Corresponds to Clients.claim() method, allows an active service worker
to set itself as the controller for all clients within its scope.

This CL mojofies the following legacy IPCs:
  ServiceWorkerHostMsg_ClaimClients
  ServiceWorkerMsg_DidClaimClients
  ServiceWorkerMsg_ClaimClientsError

BUG= 772793 

Change-Id: I50b9ee74fc67eb035578a30c78552092d57b2b6c
Reviewed-on: https://chromium-review.googlesource.com/816600
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523402}
[modify] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/third_party/WebKit/common/service_worker/service_worker.mojom
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d522872cf58566ed02cc298ce0091ee32c2dce4

commit 3d522872cf58566ed02cc298ce0091ee32c2dce4
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Wed Jan 10 02:23:44 2018

[ServiceWorker] Implement mojom interface ServiceWorkerHost.GetClients

This CL replaces native struct content::ServiceWorkerClientQueryOptions
with mojom struct blink.mojom.ServiceWorkerClientQueryOptions.

And based on that, the CL mojofies the following legacy IPCs:
ServiceWorkerHostMsg_GetClients
ServiceWorkerMsg_DidGetClients

BUG= 782528 ,  772793 

Change-Id: If72455743b2ddbef8da012831b16a9a9ce38a8ff
Reviewed-on: https://chromium-review.googlesource.com/851844
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Han Leon <leon.han@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#528219}
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/browser/service_worker/service_worker_client_utils.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/third_party/WebKit/common/service_worker/service_worker.mojom
[modify] https://crrev.com/3d522872cf58566ed02cc298ce0091ee32c2dce4/third_party/WebKit/common/service_worker/service_worker_client.mojom

Comment 10 by xiaofeng...@intel.com, Jan 10 2018

Owner: leon....@intel.com
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8898229c569b5ed2f2e11510399669ba82ce45ad

commit 8898229c569b5ed2f2e11510399669ba82ce45ad
Author: Han Leon <leon.han@intel.com>
Date: Mon Jan 22 12:38:25 2018

[ServiceWorker] Wrap Web*Callbacks thread safe for ServiceWorkerContextClient

Even if we destroyed a Mojo ThreadSafeInterfacePtr, after that those
pending response callbacks kept inside it are possible to:
  - be triggered on the calling thread (the worker thread).
or
  - be destroyed on the underlying Mojo connection binding thread (the
    IO thread).

But our Web*Callbacks is thread-hostile (MUST be destroyed on the same
thread that created it : the worker thread), so we must avoid passing
Web*Callbacks ownership into ThreadSafeInterfacePtr but should keep them
always living on the worker thread.

This CL comes up from the knowledge got via https://crbug.com/799851 and
https://chromium-review.googlesource.com/c/chromium/src/+/866212.

BUG= 772793 

Change-Id: Ie76acc5df635ae7141a0f86bf81b86165e45ef64
Reviewed-on: https://chromium-review.googlesource.com/870174
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530845}
[modify] https://crrev.com/8898229c569b5ed2f2e11510399669ba82ce45ad/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/8898229c569b5ed2f2e11510399669ba82ce45ad/content/renderer/service_worker/service_worker_context_client.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd9ac162fd838aec0f24a9ed6df1ad66f369fb1

commit fdd9ac162fd838aec0f24a9ed6df1ad66f369fb1
Author: Han Leon <leon.han@intel.com>
Date: Tue Jan 23 07:42:45 2018

[ServiceWorker] Do not skip running the response callback for GetClients().

Mojo requires impl of any interface methods MUST run the response
callback anyway before destroy it.

Before, we missed running the response callback for
blink::mojom::ServiceWorkerHost::GetClients() when we have no any valid
data to return back, this CL starts to run it with some non-sense data
(an empty vector) in such a case to let Mojo happy.

BUG= 772793 

Change-Id: I22050b9be6f38b61dd1d4442587f10dde0be45a7
Reviewed-on: https://chromium-review.googlesource.com/880404
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#531174}
[modify] https://crrev.com/fdd9ac162fd838aec0f24a9ed6df1ad66f369fb1/content/browser/service_worker/service_worker_version.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cff529b2d794c872d07f4398e8b8bb129c871f1f

commit cff529b2d794c872d07f4398e8b8bb129c871f1f
Author: Han Leon <leon.han@intel.com>
Date: Thu Jan 25 05:24:43 2018

[ServiceWorker] Send clients back for ServiceWorkerHost.GetClients() anyway

Before, we avoid sending clients back to those STOPPED/STOPPING workers
via the legacy IPC ServiceWorkerMsg_DidGetClients, maybe this is in
order to avoid stray IPC in the workers side.

After mojofication of GetClients(), we do not need to consider stray
message anymore, because we start to send clients back by running
response callback of the Mojo interface method GetClients(), which is
guaranteed to be safe no matter the other side endpoint has destroyed or
not.

BUG= 772793 

Change-Id: I2ae3e4ccf76bc4dc12d6312c694ab90cd7b9fcd7
Reviewed-on: https://chromium-review.googlesource.com/882348
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531816}
[modify] https://crrev.com/cff529b2d794c872d07f4398e8b8bb129c871f1f/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/cff529b2d794c872d07f4398e8b8bb129c871f1f/content/browser/service_worker/service_worker_version.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae2e0b3dc8785e0db950a1575944314e0dfe4aba

commit ae2e0b3dc8785e0db950a1575944314e0dfe4aba
Author: Han Leon <leon.han@intel.com>
Date: Thu Jan 25 12:58:35 2018

[ServiceWorker] Move ServiceWorkerClientInfoPtr through impl of service_worker_client_utils

This CL starts to move ServiceWorkerClientInfoPtr through impl of
service_worker_client_utils rather than passing value of
ServiceWorkerClientInfo struct.

BUG= 772793 

Change-Id: I852efee05dfda6f86b0486912827c29b00071a9d
Reviewed-on: https://chromium-review.googlesource.com/886141
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531875}
[modify] https://crrev.com/ae2e0b3dc8785e0db950a1575944314e0dfe4aba/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/ae2e0b3dc8785e0db950a1575944314e0dfe4aba/content/browser/service_worker/service_worker_client_utils.h
[modify] https://crrev.com/ae2e0b3dc8785e0db950a1575944314e0dfe4aba/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/ae2e0b3dc8785e0db950a1575944314e0dfe4aba/content/browser/service_worker/service_worker_version.h
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41d50fb43216666b4bc0601c793370f7d8e9174a

commit 41d50fb43216666b4bc0601c793370f7d8e9174a
Author: Han Leon <leon.han@intel.com>
Date: Mon Jan 29 02:56:37 2018

[ServiceWorker] Implement ServiceWorkerHost.GetClient()

This CL mojofies the 2 legacy IPCs:
  ServiceWorkerHostMsg_GetClient
  ServiceWorkerMsg_DidGetClient

BUG= 772793 

Change-Id: I3a069713c1ed0068883214c6ba583eca758ed323
Reviewed-on: https://chromium-review.googlesource.com/880486
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532309}
[modify] https://crrev.com/41d50fb43216666b4bc0601c793370f7d8e9174a/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/41d50fb43216666b4bc0601c793370f7d8e9174a/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/41d50fb43216666b4bc0601c793370f7d8e9174a/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/41d50fb43216666b4bc0601c793370f7d8e9174a/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/41d50fb43216666b4bc0601c793370f7d8e9174a/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/41d50fb43216666b4bc0601c793370f7d8e9174a/third_party/WebKit/common/service_worker/service_worker.mojom
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43f467be2ad54ee8b51bb593db99706b75da6b95

commit 43f467be2ad54ee8b51bb593db99706b75da6b95
Author: Han Leon <leon.han@intel.com>
Date: Mon Jan 29 04:05:37 2018

[ServiceWorker] Implement ServiceWorkerHost.SkipWaiting()

This CL mojofies the 2 legacy IPCs:
  ServiceWorkerHostMsg_SkipWaiting
  ServiceWorkerMsg_DidSkipWaiting

BUG= 772793 

Change-Id: Ieed08b0eec8da72d87b93500f82f74d85803545c
Reviewed-on: https://chromium-review.googlesource.com/880602
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532318}
[modify] https://crrev.com/43f467be2ad54ee8b51bb593db99706b75da6b95/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/43f467be2ad54ee8b51bb593db99706b75da6b95/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/43f467be2ad54ee8b51bb593db99706b75da6b95/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/43f467be2ad54ee8b51bb593db99706b75da6b95/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/43f467be2ad54ee8b51bb593db99706b75da6b95/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/43f467be2ad54ee8b51bb593db99706b75da6b95/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/43f467be2ad54ee8b51bb593db99706b75da6b95/third_party/WebKit/common/service_worker/service_worker.mojom
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/293e035df5adb1496e7151869c219b50a75e8387

commit 293e035df5adb1496e7151869c219b50a75e8387
Author: Han Leon <leon.han@intel.com>
Date: Thu Feb 01 11:20:40 2018

[ServiceWorker] Implement ServiceWorkerHost.{OpenNewTab,OpenPaymentHandlerWindow}

This CL mojofies the 4 legacy IPCs:
  ServiceWorkerHostMsg_OpenNewTab
  ServiceWorkerHostMsg_OpenPaymentHandlerWindow
  ServiceWorkerMsg_OpenWindowResponse
  ServiceWorkerMsg_OpenWindowError

BUG= 772793 

Change-Id: I615270782ad232a31f4568df040fdbeb82ed1679
Reviewed-on: https://chromium-review.googlesource.com/890621
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#533636}
[modify] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/content/browser/BUILD.gn
[add] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/content/browser/service_worker/payment_handler_support.cc
[add] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/content/browser/service_worker/payment_handler_support.h
[modify] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/third_party/WebKit/common/service_worker/service_worker.mojom
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/019349817400ef44b9fe4a984827dc06841b2f09

commit 019349817400ef44b9fe4a984827dc06841b2f09
Author: Han Leon <leon.han@intel.com>
Date: Wed Feb 07 06:17:08 2018

[ServiceWorker] Close the Mojo binding after reported a bad message

This is just a cleanup for ServiceWorkerVersion. As we do not expect
the connection error handler to do any extra work, we can just close the
Mojo binding of ServiceWorkerHost interface after reported a bad
message, rather than running the response callback with some nonsense
parameters.

BUG= 772793 

Change-Id: I42f5b29b6d4257ee958cb06b17277f0e0c85e8ab
Reviewed-on: https://chromium-review.googlesource.com/905752
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#534933}
[modify] https://crrev.com/019349817400ef44b9fe4a984827dc06841b2f09/content/browser/service_worker/service_worker_version.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b08e796f0822bf727ece98328fc425cad7858f88

commit b08e796f0822bf727ece98328fc425cad7858f88
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Feb 08 03:40:24 2018

Revert "[ServiceWorker] Close the Mojo binding after reported a bad message"

This reverts commit 019349817400ef44b9fe4a984827dc06841b2f09.

Reason for revert: Suspected cause of  https://crbug.com/810227 

Original change's description:
> [ServiceWorker] Close the Mojo binding after reported a bad message
> 
> This is just a cleanup for ServiceWorkerVersion. As we do not expect
> the connection error handler to do any extra work, we can just close the
> Mojo binding of ServiceWorkerHost interface after reported a bad
> message, rather than running the response callback with some nonsense
> parameters.
> 
> BUG= 772793 
> 
> Change-Id: I42f5b29b6d4257ee958cb06b17277f0e0c85e8ab
> Reviewed-on: https://chromium-review.googlesource.com/905752
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Commit-Queue: Han Leon <leon.han@intel.com>
> Cr-Commit-Position: refs/heads/master@{#534933}

TBR=falken@chromium.org,kinuko@chromium.org,shimazu@chromium.org,leon.han@intel.com

Change-Id: Iba3679b7aef3d45c381dd2464c8937a732f10444
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  772793 ,  810227 
Reviewed-on: https://chromium-review.googlesource.com/907010
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535292}
[modify] https://crrev.com/b08e796f0822bf727ece98328fc425cad7858f88/content/browser/service_worker/service_worker_version.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75abb502628ccb83b478c7a3c3dcb827bc1f7010

commit 75abb502628ccb83b478c7a3c3dcb827bc1f7010
Author: Han Leon <leon.han@intel.com>
Date: Thu Feb 08 04:43:00 2018

[ServiceWorker] Implement ServiceWorkerHost.{FocusClient,NavigateClient}

This CL:
 - mojofies the legacy IPCs:
     ServiceWorkerHostMsg_FocusClient
     ServiceWorkerHostMsg_NavigateClient
     ServiceWorkerMsg_FocusClientResponse
     ServiceWorkerMsg_NavigateClientResponse
     ServiceWorkerMsg_NavigateClientError
 - eliminates the legacy IPC EmbeddedWorkerContextMsg_MessageToWorker as
   its last users have gone away, embedded worker context won't receive
   any legacy IPCs from now on.
 - eliminates some infra codes sending/receiving
   EmbeddedWorkerContextMsg_MessageToWorker.

BUG= 772793 

Change-Id: Ieda392b9323bf3a22249251d31c611c01a6d39d7
Reviewed-on: https://chromium-review.googlesource.com/906005
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535300}
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/browser/service_worker/embedded_worker_registry.cc
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/browser/service_worker/embedded_worker_registry.h
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/common/service_worker/embedded_worker_messages.h
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/renderer/BUILD.gn
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/content/renderer/service_worker/service_worker_context_client.h
[delete] https://crrev.com/021c2a9786554cc2c7f8bbcaa7cbe52e995e462f/content/renderer/service_worker/service_worker_context_message_filter.cc
[delete] https://crrev.com/021c2a9786554cc2c7f8bbcaa7cbe52e995e462f/content/renderer/service_worker/service_worker_context_message_filter.h
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/ipc/ipc_message_start.h
[modify] https://crrev.com/75abb502628ccb83b478c7a3c3dcb827bc1f7010/third_party/WebKit/common/service_worker/service_worker.mojom
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc78764085816e10b1fb89394c849ebc7ff1f15e

commit cc78764085816e10b1fb89394c849ebc7ff1f15e
Author: Han Leon <leon.han@intel.com>
Date: Wed Feb 28 05:05:58 2018

[ServiceWorker] Use null ServiceWorkerClientInfoPtr for an invalid info

Rather than a non-null ServiceWorkerClientInfoPtr with an empty client
uuid, this CL starts to use a null ServiceWorkerClientInfoPtr to
indicate an invalid client info.

BUG= 772793 

Change-Id: I753dd87da32053e68eb6dfec104463694312e65b
Reviewed-on: https://chromium-review.googlesource.com/930665
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539713}
[modify] https://crrev.com/cc78764085816e10b1fb89394c849ebc7ff1f15e/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/cc78764085816e10b1fb89394c849ebc7ff1f15e/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/cc78764085816e10b1fb89394c849ebc7ff1f15e/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/cc78764085816e10b1fb89394c849ebc7ff1f15e/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/cc78764085816e10b1fb89394c849ebc7ff1f15e/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/cc78764085816e10b1fb89394c849ebc7ff1f15e/third_party/WebKit/public/mojom/service_worker/service_worker.mojom
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c54383cb181286bf5890687f987dff17212e1475

commit c54383cb181286bf5890687f987dff17212e1475
Author: Han Leon <leon.han@intel.com>
Date: Fri Mar 02 12:15:00 2018

[ServiceWorker] Implement EmbeddedWorkerInstanceHost.CountFeature

This CL mojofies the legacy IPC EmbeddedWorkerHostMsg_CountFeature.
After that eliminates embedded_worker_messages.h.

BUG= 772793 

Change-Id: I1b50b37344be8613faede665c44295a7eba91f81
Reviewed-on: https://chromium-review.googlesource.com/909922
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540499}
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/embedded_worker_registry.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_handle_unittest.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/common/BUILD.gn
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/common/content_message_generator.h
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/common/service_worker/embedded_worker.mojom
[delete] https://crrev.com/9e4e912b43862b77a6e6383ace16765b7c89a77c/content/common/service_worker/embedded_worker_messages.h
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/ipc/ipc_message_start.h
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/c54383cb181286bf5890687f987dff17212e1475/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efa4867fb774e379e3761f80af1118ce2b3e33b0

commit efa4867fb774e379e3761f80af1118ce2b3e33b0
Author: Han Leon <leon.han@intel.com>
Date: Tue Mar 13 09:22:51 2018

[ServiceWorker] Report bad message on receiving Client#{*} calls from a cross-origin client

All JavaScript Client objects seen in a service worker execution context
must be matching origin with the service worker (See the bellowing
explanation in details), so, if the browser-side received a
Client#{postMessage,focus,navigate} call from a cross-origin Client
object, it should be treated as a bad message.

A detailed explanation:
Once a JavaScript Client object has been gotten by the
ServiceWorkerGlobalScope (via ServiceWorkerGlobalScope#{Clients,Client}
APIs), the corresponding window client navigation (including page
redirects) must have already completed and its origin should be matching
with the service worker.
And, for a window client, once the initial navigation done, its document
url won't be changed any more, so its origin should keep matching with
the service worker through its lifetime.
Even in case that the window starts to navigate to another url, a new
ServiceWorkerProviderHost with a new client uuid will be created for
that, without any changes to document url of the original
ServiceWorkerProviderHost.
As above, we're sure a Client#{*} request received in browser-side must
be for a client matching origin with the sender service worker.

BUG= 772793 

Change-Id: I821c8cced03288596988d583637157e8f1839b2b
Reviewed-on: https://chromium-review.googlesource.com/956111
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542750}
[modify] https://crrev.com/efa4867fb774e379e3761f80af1118ce2b3e33b0/content/browser/service_worker/service_worker_version.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94335e49e0bde3ca950ac31030841d00a2ec0a3a

commit 94335e49e0bde3ca950ac31030841d00a2ec0a3a
Author: Han Leon <leon.han@intel.com>
Date: Thu Mar 15 08:44:18 2018

[ServiceWorker] Implement ServiceWorkerHost.PostMessageToClient()

This CL
 - mojofies the legacy IPC ServiceWorkerHostMsg_PostMessageToClient,
   which is the last one service worker legacy IPC sent from the
   renderer process to the browser process.
 - eliminates some infra codes sending service worker legacy IPCs in
   renderer-side.
 - eliminates some infra codes receiving service worker legacy IPCs in
   browser-side.
 - modifies some related tests.

BUG= 772793 

Change-Id: I81652b2f5c2693eef731faca0a09fd1aa5ad7404
Reviewed-on: https://chromium-review.googlesource.com/947804
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#543327}
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/embedded_worker_registry.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/embedded_worker_registry.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/web_service_worker_impl.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/web_service_worker_impl.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/content/renderer/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/third_party/WebKit/public/mojom/BUILD.gn
[modify] https://crrev.com/94335e49e0bde3ca950ac31030841d00a2ec0a3a/third_party/WebKit/public/mojom/service_worker/service_worker.mojom

Comment 25 by leon....@intel.com, Mar 16 2018

Status: Fixed (was: Assigned)

Comment 26 by falken@chromium.org, Jul 3

Labels: M-67
►

Sign in to add a comment