Regression: Focus is seen chopped on LHS for 'permalink' on chrome://flags.
Reported by
aiman.an...@etouch.net,
Oct 9 2017
|
|||
Issue descriptionChrome Version: 63.0.3235.0 (Official Build) bed9197136dcd4dac7e3856b56e8e4680c2fafb4-refs/heads/master@{#507234} OS: Mac(10.12.6). Steps to reproduce: 1.Launch Chrome, go to chrome://flags press tab 5 times till focus reaches ’permalink’ and observe. Actual Result: Focus is seen chopped on LHS. Expected Result: Focus should not be seen chopped on LHS. This is regression issue broken in ‘M-63’ and will soon update the bisect info. Using the per-revision bisect providing the bisect results, Good Build: 63.0.3234.0 Bad Build: 63.0.3235.0 Note: Above issue is not seen on Win and Linux OS.
,
Oct 9 2017
Using the per-revision bisect providing the bisect results, Good Build: 63.0.3234.0(Revision: 506937) Bad Build: 63.0.3235.0(Revision: 507234) You are probably looking for a change made after 507084 (known good), but no later than 507085 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/9596258909269fd6b02fca48186dc9c72cd3ef74..e08766ea8fe70ad0fcd967351063e6b3b32f82b0 Suspect: https://chromium.googlesource.com/chromium/src/+/e08766ea8fe70ad0fcd967351063e6b3b32f82b0 @edwardjung: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Oct 9 2017
Thanks. Can verify. I'll put in a fix. Also seen on Linux builds.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fc5451ac52eac5f141b72af906cb794baa1699b commit 0fc5451ac52eac5f141b72af906cb794baa1699b Author: Edward Jung <edwardjung@chromium.org> Date: Thu Oct 12 08:56:53 2017 Updated chrome://flags UI bug fixes + Focus outlines on buttons are now styled rather than the large default blur. + Fixed the cropped focus outline due to overflow:hidden being set on the experiment container. + Remove elided description text, so full text search works properly. + Hide the 'Beta' promo statement by default. + Add hover styles for buttons. + Improve RTL layout + Force scrollbar to fix annoying layout shift + Add listener for '/' to focus search box. + Add a proper tab index order + Uppercase formatting for Restart button Bug: 772792 , 773079 , 772968 , 772851 , 772809 , 772807 , 772792 , 772784 , 772781 Change-Id: I9a9c08c2e8aef517d6d0c6e2ac8b634b69a1c6a1 Reviewed-on: https://chromium-review.googlesource.com/707252 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#508286} [modify] https://crrev.com/0fc5451ac52eac5f141b72af906cb794baa1699b/components/flags_ui/resources/flags.css [modify] https://crrev.com/0fc5451ac52eac5f141b72af906cb794baa1699b/components/flags_ui/resources/flags.html [modify] https://crrev.com/0fc5451ac52eac5f141b72af906cb794baa1699b/components/flags_ui/resources/flags.js
,
Oct 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted