Overlapping of text is seen on close(x) button in chrome://flags
Reported by
nutan.ga...@etouch.net,
Oct 9 2017
|
|||||||||||||||
Issue descriptionChrome Version: 63.0.3235.0 bed9197136dcd4dac7e3856b56e8e4680c2fafb4-refs/heads/master@{#507234} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6) Steps to Reproduce? 1. Launch Chrome, navigate to chrome://flags 2. Press cmd+F to open 'Find' box and enter 'rtl' 3. Enable 'Force UI direction' to 'Right-to-Left' and Relaunch chrome 4. Observe the text in search box Actual: Overlapping of text is seen on close(x) button in Search box Expected: Overlapping of text should not be seen on close(x) button This is an Non-Regression issue seen form M-63 i.e. 63.0.3235.0
,
Oct 9 2017
,
Oct 9 2017
Thanks for catching this. I'll double check the RTL formatting.
,
Oct 10 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fc5451ac52eac5f141b72af906cb794baa1699b commit 0fc5451ac52eac5f141b72af906cb794baa1699b Author: Edward Jung <edwardjung@chromium.org> Date: Thu Oct 12 08:56:53 2017 Updated chrome://flags UI bug fixes + Focus outlines on buttons are now styled rather than the large default blur. + Fixed the cropped focus outline due to overflow:hidden being set on the experiment container. + Remove elided description text, so full text search works properly. + Hide the 'Beta' promo statement by default. + Add hover styles for buttons. + Improve RTL layout + Force scrollbar to fix annoying layout shift + Add listener for '/' to focus search box. + Add a proper tab index order + Uppercase formatting for Restart button Bug: 772792 , 773079 , 772968 , 772851 , 772809 , 772807 , 772792 , 772784 , 772781 Change-Id: I9a9c08c2e8aef517d6d0c6e2ac8b634b69a1c6a1 Reviewed-on: https://chromium-review.googlesource.com/707252 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#508286} [modify] https://crrev.com/0fc5451ac52eac5f141b72af906cb794baa1699b/components/flags_ui/resources/flags.css [modify] https://crrev.com/0fc5451ac52eac5f141b72af906cb794baa1699b/components/flags_ui/resources/flags.html [modify] https://crrev.com/0fc5451ac52eac5f141b72af906cb794baa1699b/components/flags_ui/resources/flags.js
,
Oct 13 2017
Retested the above issue on latest Canary #63.0.3239.0 on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6) and fix is working as intended. Kindly refer the attached video
,
Oct 13 2017
,
Oct 13 2017
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Oct 9 2017