New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772782 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Unnecessary close icon appears in search box even when no text is entered in chrome://flags page.

Reported by rp...@etouch.net, Oct 9 2017

Issue description

Version: 63.0.3235.0 bed9197136dcd4dac7e3856b56e8e4680c2fafb4-refs/heads/master@{#507234}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6)

What steps will reproduce the problem?
1. Launch chrome, navigate chrome://flags and observe search box.

Actual: Unnecessary close icon appears in search box even when no text is entered
Expected: Close icon should not appear in search box when no text is entered

This is a non-regression issue, seen from M-63 series as in 'Chrome://flags' Availabe and unavailabe option appears from build # 63.0.3235.0

Kindly review the attached screenshot for reference.
 
Actual_screenshot.png
158 KB View Download
Status: Untriaged (was: Unconfirmed)
Untriaged it so that issue gets addressed.

Thanks.!
Cc: edwardjung@chromium.org
Cc: -edwardjung@chromium.org
Components: -Internals UI>Browser>WebUI
Owner: edwardjung@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd64a192d8b8a180fb40f389f4ecf8680467e968

commit dd64a192d8b8a180fb40f389f4ecf8680467e968
Author: Edward Jung <edwardjung@chromium.org>
Date: Mon Oct 30 14:59:22 2017

chrome://flags UI tweaks

+ Hide the clear search button when there is no search entry.
+ Style improvements on iOS where Roboto is not loaded.
+ Switch the 'tick' indicator to a generic dot removing confusion as 
  whether it indicates 'enabled'.

Bug:  772782 , 772954 
Change-Id: I26d208e45fdb64a0d8c922d377164f5a25a6d681
Reviewed-on: https://chromium-review.googlesource.com/735604
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512494}
[modify] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/components/flags_ui/resources/flags.css
[modify] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/components/flags_ui/resources/flags.html

Comment 5 by rp...@etouch.net, Oct 31 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3254.0
Note : Rechecked the above issue on Windows 8 OS with latest canary chrome version : 64.0.3254.0 and the issue is not reproducible.Kindly refer the attached screen cast for reference.
Actual_video.mp4
118 KB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment