New issue
Advanced search Search tips

Issue 772768 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::StyleEngine::EnsureUAStyleForFullscreen

Project Member Reported by ClusterFuzz, Oct 9 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6030687152111616

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000b0
Crash State:
  blink::StyleEngine::EnsureUAStyleForFullscreen
  blink::Element::SetContainsFullScreenElementOnAncestorsCrossingFrameBoundaries
  blink::Element::InsertedInto
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=495320:495357

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6030687152111616

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 9 2017

Components: Blink>CSS Blink>DOM
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 9 2017

Labels: Test-Predator-AutoOwner
Owner: sunxd@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/6be43e7f8e0806cf773ffdd1adb91811740c9ed3 (Compute touch-action for replaced canvas).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Components: -Blink>CSS

Comment 4 by kochi@chromium.org, Oct 10 2017

Components: -Blink>DOM Blink>Fullscreen
Sounds more like a fullscreen issue, rather than generic DOM issue.

Comment 5 by sunxd@chromium.org, Oct 10 2017

Cc: flackr@chromium.org xidac...@chromium.org
The test case (both minimized and regular) keeps reloading the window and I cannot reproduce the null dereference on my local machine. It also makes no difference reverting the suspected patch.

I make the test rerun the minimized test case and blame. It might have something to do with iframes since the cl changes logic of propagating styles across frames.

Comment 6 by sunxd@chromium.org, Oct 10 2017

Cc: sunxd@chromium.org
Owner: iclell...@chromium.org
The new suspected cl points to https://chromium.googlesource.com/chromium/src/+/5d8010e1fc081481d0646618e700b51a4699ab4c

While I'm not sure whether the bisect is correct or not, we need to a fullscreen expert to provide some insight on this.

iclelland@, please take a look at this issue and re-assign if it is not related to your change.
Project Member

Comment 7 by ClusterFuzz, Oct 15 2017

ClusterFuzz has detected this issue as fixed in range 508937:508940.

Detailed report: https://clusterfuzz.com/testcase?key=6030687152111616

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000b0
Crash State:
  blink::StyleEngine::EnsureUAStyleForFullscreen
  blink::Element::SetContainsFullScreenElementOnAncestorsCrossingFrameBoundaries
  blink::Element::InsertedInto
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=495320:495357
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=508937:508940

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6030687152111616

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Oct 15 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6030687152111616 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner

Sign in to add a comment