New issue
Advanced search Search tips

Issue 772764 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Prevent sites from creating pop-unders.

Project Member Reported by ojan@chromium.org, Oct 9 2017

Issue description

Chrome Version: 63.0.3225.0 (Official Build) canary (64-bit)

What steps will reproduce the problem?
(1) Go to http://www.vidzi.cc/o3gpya9a3med
(2) Click on the video
(3) Page creates a popup and then uses a PDF viewer modal dialog to get focus back to the original tab.

Sometimes it doesn't happen. Click on the full screen button repeatedly to get it to happen again.

Looks like the fix for this regressed?
 
video.mp4
1.6 MB View Download

Comment 1 by a...@chromium.org, Oct 9 2017

Are you seeing a popunder? In your video, and in my experimentation, you're getting a tab-under, not a popunder.

We don't have good tab-under prevention, and the popunder prevention is for popunders only.

Comment 2 by ojan@chromium.org, Oct 9 2017

Summary: tabunder with pdf dialog (was: popunder)
Whoops...I had a placeholder for the summary of the bug while I got the screen capture and forgot to actually fill it out. Yes, this is tabunder. :)

Comment 3 by a...@chromium.org, Oct 9 2017

My removal of activation from alert() will certainly help here :) though I imagine that they'll just hop from dialog to dialog that has the ability to activate until I remove activation from everything.

Comment 4 by a...@chromium.org, Oct 11 2017

Issue 737017 has been merged into this issue.

Comment 5 by a...@chromium.org, Oct 11 2017

Labels: alert-activation

Comment 6 by ojan@chromium.org, Oct 13 2017

The reason people use this is that the dialog can be closed by the web page. For alert/confirm/prompt, the user has to be the one to do it. Maybe we should start with the removal of activation from dialogs that can be auto-closed?

That said, Jochen had fixed this with a stopgap by refocusing the tab that was focused when dialog was first opened. Jochen, did that code get reverted?

Comment 7 by a...@chromium.org, Oct 13 2017

"Maybe we should start with the removal of activation from dialogs that can be auto-closed?"

I'm working on removing activation from all dialogs. alert() dialogs are first.
Owner: a...@chromium.org
Status: Assigned (was: Untriaged)
Summary: Prevent sites from creating pop-unders. (was: tabunder with pdf dialog)

Comment 9 by a...@chromium.org, Jun 8 2018

Status: Fixed (was: Assigned)
Dialogs no longer activate with  bug 849816 . Closing; if any new pop-under techniques are invented, file new bugs.

Sign in to add a comment