New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772755 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

PWA notification sometime gets stuck after quitting a PWA.

Project Member Reported by piotrs@chromium.org, Oct 8 2017

Issue description

Chrome Version: most recent one as of filing.
OS: Android

The bug is that PWA Persistent notification should only be present when PWA is in the foreground. It should disappear if user switches the context to different app. Sometimes however this doesn't happen and notification stays up after navigating away from the PWA.
 
I could not reproduce this predictably, but have seen this happening at least once myself, and there's a report from klobag@. At this point I unfortunately don't have a clue why it's happening.

Comment 2 by piotrs@chromium.org, Oct 10 2017

Found the cause - it happens when user quits PWA while the navigation is in progress. Even though PWA is no longer visible, notification can get shown in after the navigation finishes in order to update the URL - which is a bug.

Fix coming soon.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a81504d9fe06d98db2161563600ac4a43be1ffe

commit 3a81504d9fe06d98db2161563600ac4a43be1ffe
Author: Piotr Swigon <piotrs@chromium.org>
Date: Tue Oct 10 03:29:46 2017

[WebApps] Update the URL in a notification only if activity is active.

This fixes a bug where a webapp notification could have been shown after
webapp window has been closed. This could have happened if the user
closed the webapp activity while navigation was in progress.

Unfortunately no test, as this is a race condition and test is likely to
be flaky or not effective.

Bug:  772755 
Change-Id: I4987c6a474f0b3d0d55a44d34ecab03f6fecb990
Reviewed-on: https://chromium-review.googlesource.com/708174
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507579}
[modify] https://crrev.com/3a81504d9fe06d98db2161563600ac4a43be1ffe/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Comment 4 by piotrs@chromium.org, Oct 10 2017

Status: Fixed (was: Assigned)
This should no longer happen. Marking as Fixed.

Sign in to add a comment