New issue
Advanced search Search tips

Issue 772679 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
h...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 765335



Sign in to add a comment

ClangToTLinuxMSan fails compile

Project Member Reported by thakis@chromium.org, Oct 7 2017 
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClangToTLinuxMSan%2F93%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

FAILED: obj/third_party/instrumented_libraries/msan-chained-origins.txt 
python ../../third_party/instrumented_libraries/scripts/unpack_binaries.py msan-chained-origins /b/c/builder/ClangToTLinuxMSan/src/third_party/instrumented_libraries/binaries /b/c/builder/ClangToTLinuxMSan/src/out/Release/instrumented_libraries_prebuilt obj/third_party/instrumented_libraries
tar (child): /b/c/builder/ClangToTLinuxMSan/src/third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
Traceback (most recent call last):
  File "../../third_party/instrumented_libraries/scripts/unpack_binaries.py", line 42, in <module>
    sys.exit(main(*sys.argv[1:]))
  File "../../third_party/instrumented_libraries/scripts/unpack_binaries.py", line 29, in main
    target_dir])
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['tar', '-zxf', '/b/c/builder/ClangToTLinuxMSan/src/third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz', '-C', '/b/c/builder/ClangToTLinuxMSan/src/out/Release/instrumented_libraries_prebuilt']' returned non-zero exit status 2


The download script currently wants a certain GYP_DEFINE: https://cs.chromium.org/chromium/src/third_party/instrumented_libraries/scripts/download_binaries.py?sq=package:chromium&l=49

Need this: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/config.py?type=cs&q=use_prebuilt_instrumented_libraries+file:recipe&sq=package:chromium&l=488


Also on the new bot: https://build.chromium.org/p/chromium.clang/builders/ToTLinuxMSan

Comment 1 by thakis@chromium.org, Oct 7 2017

Blocking: 765335

Comment 3 by dpranke@chromium.org, Oct 8 2017 

See crrev.com/c/706280 for an alternate approach where we'll just download the libraries unconditionally, as discussed.

Comment 5 by h...@chromium.org, Oct 9 2017 

The bots are failing to download:

From https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxMSan/builds/119

________ running '/usr/bin/python src/third_party/instrumented_libraries/scripts/download_binaries.py' in '/b/c/builder/ClangToTLinuxMSan'
Traceback (most recent call last):
  File "src/third_party/instrumented_libraries/scripts/download_binaries.py", line 71, in <module>
    sys.exit(main(sys.argv[1:]))
  File "src/third_party/instrumented_libraries/scripts/download_binaries.py", line 55, in main
    archive_name = get_archive_name(gyp_defines)
  File "src/third_party/instrumented_libraries/scripts/download_binaries.py", line 44, in get_archive_name
    return "%s-%s.tgz" % (get_configuration(gyp_defines), get_ubuntu_release())
  File "src/third_party/instrumented_libraries/scripts/download_binaries.py", line 40, in get_configuration
    "Prebuilt instrumented libraries not available for your configuration.")
Exception: Prebuilt instrumented libraries not available for your configuration.
Error: Command '/usr/bin/python src/third_party/instrumented_libraries/scripts/download_binaries.py' returned non-zero exit status 1 in /b/c/builder/ClangToTLinuxMSan
step returned non-zero exit code: 2
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c360be067fff0a502f1492522eff5456429fa34

commit 6c360be067fff0a502f1492522eff5456429fa34
Author: Dirk Pranke <dpranke@chromium.org>
Date: Mon Oct 09 19:06:59 2017

Check out the msan instrumented libraries by default.

Now that we have conditional support in DEPS, and have a policy
of "download everything the main bots need" by default, we
can download the instrumented libraries using the stock
download script, and delete the custom script that uses GYP_DEFINES.

Checking out the libraries adds 360MB for the no_origins version
and 2161MB for the chained_origins version. You can skip the
downloads by setting `"checkout_instrumented_libraries": False`
in the custom_vars section of your .gclient file (or by passing 
`--custom-var=checkout_instrumented_libraries=False` when running
`gclient config`). Passing `checkout_configuration="small"` will
also skip the download, along with multiple other optional things.

R=thakis@chromium.org, phajdan.jr@chromium.org
BUG= 570091 ,  772679 

Change-Id: I14aa5d9b809217d31459232a00f6918093c47ad0
Reviewed-on: https://chromium-review.googlesource.com/706280
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507438}
[modify] https://crrev.com/6c360be067fff0a502f1492522eff5456429fa34/DEPS
[delete] https://crrev.com/2d475c3fdc36b3d761ce1838caded3d47e70f4df/third_party/instrumented_libraries/scripts/download_binaries.py

Comment 8 by dpranke@chromium.org, Oct 10 2017

Status: Fixed (was: Started)
This should be fixed now (or, at least, compile is failing for other reasons :).
►

Sign in to add a comment