New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772615 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in chrome_pdf::PDFiumEngine::TraverseBookmarks

Project Member Reported by ClusterFuzz, Oct 7 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5020363204591616

Fuzzer: ochang_neurofuzz_mutator
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x0701196c
Crash State:
  chrome_pdf::PDFiumEngine::TraverseBookmarks
  chrome_pdf::PDFiumEngine::TraverseBookmarks
  chrome_pdf::PDFiumEngine::TraverseBookmarks
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=507165:507202

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5020363204591616

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 7 2017

Components: Internals>Plugins>PDF
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 7 2017

Labels: Test-Predator-AutoOwner
Owner: hnakashima@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/9d9e0630b91da3dfa6ad49a29a5dd97d11f6baca (PDF Viewer: more precise bookmark navigation).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Cc: thestig@chromium.org
Labels: M-63 Pri-1
Cc: -thestig@chromium.org hnakashima@chromium.org
Labels: OS-Chrome OS-Linux OS-Mac
Owner: thestig@chromium.org
Status: Started (was: Assigned)
Horray for fuzzers! https://chromium-review.googlesource.com/706300
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 7 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by ClusterFuzz, Oct 10 2017

Labels: ClusterFuzz-Top-Crash ReleaseBlock-Beta
Testcase 5020363204591616 is a top crash on ClusterFuzz for mac platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 7 by gov...@chromium.org, Oct 10 2017

M63 is branching on this Thursday (10/12) and M63 beta promotion is coming very soon. Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP. Thank you.
Cc: kushal89...@gmail.com
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/686a540a548894aaff894d58a4694d0ef22aa192

commit 686a540a548894aaff894d58a4694d0ef22aa192
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Oct 10 22:20:06 2017

Check page number values in PDFiumEngine::TraverseBookmarks().

This is a regression in r507184.

BUG= 772615 

Change-Id: I90a8f913544051a8f1f4eef03e96138a5e624c21
Reviewed-on: https://chromium-review.googlesource.com/706300
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507795}
[modify] https://crrev.com/686a540a548894aaff894d58a4694d0ef22aa192/pdf/pdfium/pdfium_engine.cc

Status: Fixed (was: Started)
Project Member

Comment 11 by ClusterFuzz, Oct 11 2017

ClusterFuzz has detected this issue as fixed in range 507774:507842.

Detailed report: https://clusterfuzz.com/testcase?key=5020363204591616

Fuzzer: ochang_neurofuzz_mutator
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x0701196c
Crash State:
  chrome_pdf::PDFiumEngine::TraverseBookmarks
  chrome_pdf::PDFiumEngine::TraverseBookmarks
  chrome_pdf::PDFiumEngine::TraverseBookmarks
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=507165:507202
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=507774:507842

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5020363204591616

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Oct 11 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5020363204591616 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 11 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta -ReleaseBlock-Stable
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Cc: thestig@chromium.org
 Issue 772616  has been merged into this issue.
Project Member

Comment 18 by sheriffbot@chromium.org, Jan 17 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-63 M-65 Security_Impact-Stable

Sign in to add a comment