New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772599 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 640685



Sign in to add a comment

Quick view: break down 'other' in FileBrowser.QuickView.FileType metric

Project Member Reported by oka@chromium.org, Oct 7 2017

Issue description

'other' occupies 12% of the files opened by quick view.

Let's break down it to
- folder
- no extension
- unknown extension
for better understanding of Quick View usage.
 

Comment 1 by oka@chromium.org, Oct 7 2017

Components: Platform>Apps>FileManager

Comment 2 by oka@chromium.org, Oct 7 2017

Cc: fukino@chromium.org
Labels: M-64
Labels: -M-64 M-65
Blocking: 640685
Labels: -M-65 M-66
Labels: Hotlist-GoodFirstBug
Owner: sashab@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eda4e5f9d95b57e3b6a473b0bf249728999e5001

commit eda4e5f9d95b57e3b6a473b0bf249728999e5001
Author: Sasha Morrissey <sashab@chromium.org>
Date: Mon Feb 12 04:22:26 2018

Break down 'other' in FileBrowser.QuickView.FileType UMA

Break down 'other' in FileBrowser.QuickView.FileType UMA to 'directory',
'no extension' and 'unknown extension'.

extension and a file with a .gn extension. Then check
values 59 through 62 inclusive

Bug:  772599 
Test: Quick View and Open on a folder, a .zip file, a file without an
chrome: //histograms has 4 entries for FileBrowser.QuickView.FileType,
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id13b8734e96b238bfb98b98b0062d1f0721180c7
Reviewed-on: https://chromium-review.googlesource.com/907992
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536027}
[modify] https://crrev.com/eda4e5f9d95b57e3b6a473b0bf249728999e5001/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/eda4e5f9d95b57e3b6a473b0bf249728999e5001/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/eda4e5f9d95b57e3b6a473b0bf249728999e5001/ui/file_manager/file_manager/foreground/js/quick_view_uma.js

Status: Fixed (was: Assigned)
Labels: CrOS-FilesApp-QuickView
<files-triage>
Status: Verified (was: Fixed)

Sign in to add a comment