New issue
Advanced search Search tips

Issue 772594 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add encryption test to encrypted_messages component

Project Member Reported by carlosil@chromium.org, Oct 7 2017

Issue description

Current tests for encrypted_messages only validate a (already encrypted and serialized) message can be decrypted. There should be a test that checks a message can be encrypted (and subsequently decrypted).
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f71d19bf8c44c7fc8ae23db3274d50a6344d5132

commit f71d19bf8c44c7fc8ae23db3274d50a6344d5132
Author: Carlos IL <carlosil@chromium.org>
Date: Tue Oct 24 17:22:02 2017

Added a test that checks a message matches the original after being
encrypted and decrypted.

Added a test for encrypted_messages that checks a message can be
encrypted and decrypted, and then checks that the decrypted message
matches the original. A function was added to message_encrypter that
allows a fixed private key to be used for testing.

Bug:  772594 

Change-Id: Idad499c36ea4f1d09999d70946986b5ba867ddd5
Reviewed-on: https://chromium-review.googlesource.com/707592
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511191}
[modify] https://crrev.com/f71d19bf8c44c7fc8ae23db3274d50a6344d5132/components/encrypted_messages/BUILD.gn
[modify] https://crrev.com/f71d19bf8c44c7fc8ae23db3274d50a6344d5132/components/encrypted_messages/message_encrypter_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment