[CRD iOS] Multiple issues related to MDCFlexibleHeaderView |
||||||
Issue descriptionMultiple issues related to MDCFlexibleHeaderView occurred after a recent MaterialComponents roll. Issues: 1. After switching accounts from the SSO drawer, the host list may get stuck in a weird scroll position. 2. Weird shadow occurs between the nav bar and the menu content in the settings menu.
,
Oct 7 2017
,
Oct 7 2017
ios/third_party/material_components_ios/src/components/Collections/src: v35.2.0: no bugs v35.3.0: bugs
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8c8373b0c49aa06be3da51213b2c1581263fdc6 commit d8c8373b0c49aa06be3da51213b2c1581263fdc6 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Oct 13 22:38:50 2017 [CRD iOS] Fix extra shadow on the settings view This CL fixes the extra shadow shown below the app bar on the settings view (showing since the last MaterialComponents update) by moving initialization code to viewDidLoad. TBH I'm not sure the shadow started showing up and why moving the initialization code to viewDidLoad fixes the problem. It could be that the app bar is added to the view controller before the view is created and caused some unexpected behavior. Generally it is a good idea to add non-blocking initialization code to viewDidLoad instead of init. Bug: 772578 Change-Id: I532f7af475616a4e525a7059a9ece05add276cbd Reviewed-on: https://chromium-review.googlesource.com/717820 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#508854} [modify] https://crrev.com/d8c8373b0c49aa06be3da51213b2c1581263fdc6/remoting/ios/app/settings/remoting_settings_view_controller.mm
,
Oct 17 2017
,
Oct 19 2017
,
Oct 24 2017
Tried with MDC v37.0.0 (with some hacks) and look like layout bugs are all fixed. We still don't know when the MDC autoroller will be fixed though...
,
Oct 30 2017
,
Nov 3 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yuweih@chromium.org
, Oct 7 2017Summary: [CRD iOS] Multiple issues related to MDCFlexibleHeaderView (was: [CRD iOS] Weird shadow showing below the setting menu's navigation bar)