New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772577 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug

Blocking:
issue 765834



Sign in to add a comment

No Predator result for these testcases

Project Member Reported by infe...@chromium.org, Oct 6 2017

Issue description

We should never ever have a case for this. But seems like we do, can you please check

https://clusterfuzz.com/v2/testcase-detail/6129151760400384
https://clusterfuzz.com/v2/testcase-detail/5521939769851904

Suspecting this from logs

Request to https://chromium.googlesource.com/breakpad/breakpad/+log/None..1c6d1613966eab5d77531e85f3b60c40124b43f0?format=json&name-status=1&n=1000 resulted in 404, headers:[["content-length", "1603"], ["expires", "Mon, 01 Jan 1990 00:00:00 GMT"], ["x-content-type-options", "nosniff"], ["set-cookie", "gi=mogbm58jhJR1KWqM12jqGWW8MVLfcRjmDBRZda9qpYo=findit-for-me.google.com%40appspot.gserviceaccount.com;Path=/;Secure"], ["strict-transport-security", "max-age=31536000; includeSubDomains; preload"], ["x-errorid", "404, EFERW-291,EFERW-277,VF-118,AHF-31,VF-38,UPC-242,RF-50,AHF-31,UPC-242,UP-221,RP-151,MF-178,MS-134,DFDESF-373,GQF-70,GQF-59,GSF-26,MF-180,GGF-152,OGCWF-35,HMF-189,AF-196,GGFBSLRF-91,GGFBUELRF-177,SCZFI-157,CWHF-113,CRF-94,CAF-129,SSF-25,GUUAF-140,MHF-109,EF-223,GAEF-72,GBLHCF-114,STSF-151,SF-63,EBF-68,TTLF-154,PLRHF-268,IIIHF-46,DF-173,DF-63,EUCDLF-111,GSI-75,RR-111"], ["x-xss-protection", "1; mode=block"], ["pragma", "no-cache"], ["cache-control", "no-cache, no-store, max-age=0, must-revalidate"], ["date", "Fri, 06 Oct 2017 20:33:57 GMT"], ["x-frame-options", "SAMEORIGIN"], ["alt-svc", "quic=\":443\"; ma=2592000; v=\"39,38,37,35\""], ["content-type", "text/html; charset=utf-8"]] (/base/data/home/apps/s~google.com:findit-for-me/backend-clusterfuzz:8f9b2c563.404597803774375721/first_party/gae_libs/http/http_client_appengine.py:48)

Please start looking at this list
https://clusterfuzz.com/v2/testcases?open=yes&project=chromium&reproducible=yes
and ensure that first 5 pages have result for every testcase.
 
Cc: mbarbe...@chromium.org
Labels: -Pri-1 Pri-0
Like reliability issue, this is P0 for next week. We need to make sure that there are no silent failures. Luckily, other testcases have results, so this time server is still processing.
Status: Started (was: Assigned)
There will be 2 fixes, one is to fix the None..rev bug, the other is to push error message to clusterfuzz when Predator analysis failed.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/054c5c1c498bc640ccbf14f7c64088bc42715069

commit 054c5c1c498bc640ccbf14f7c64088bc42715069
Author: Sharu Jiang <katesonia@google.com>
Date: Tue Oct 10 18:07:37 2017

[Findit] Get changelogs in (None, '123'] or ('123', None] ranges.

Bug:  772577 
Change-Id: I08ee042cb121b98171e95b4e390e318718d25d09
Reviewed-on: https://chromium-review.googlesource.com/706862
Commit-Queue: Sharu Jiang <katesonia@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/054c5c1c498bc640ccbf14f7c64088bc42715069/appengine/findit/libs/gitiles/test/gitiles_repository_test.py
[modify] https://crrev.com/054c5c1c498bc640ccbf14f7c64088bc42715069/appengine/findit/libs/gitiles/gitiles_repository.py

Please remember to run Predator on all these testcases after the fixes are in.

Comment 6 by aarya@google.com, Oct 14 2017

Please prioritize the fixing of pushing of error message to clusterfuzz part as well. This was also needed for other things like "no regression range", or "regression range too large 0:X", etc ?
I still see testcases missing results, e.g, https://clusterfuzz.com/v2/testcase-detail/4565231459368960
Status: Fixed (was: Started)
This should be fixed as well. If any test cases have no result showing, they should work after a redo.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bdf91f698b5669dc77a6aa7255fc6672525aa3fa

commit bdf91f698b5669dc77a6aa7255fc6672525aa3fa
Author: Sharu Jiang <katesonia@google.com>
Date: Tue Dec 05 22:38:14 2017

[Predator] Handle and push back error message and result when there are errors in analysis.

Previous change(https://chromium-review.googlesource.com/c/infra/infra/+/756282) make sure that Predator will run PublishResultPipeline for every crash, but if there are errors (analysis.status is ERROR), predator will be silent and won't push back messages to clusterfuzz.
Now change Predator return a {'found': False} if error occurred and there is no result computed before the error, and return its logging as well.

Bug:  772577 
Change-Id: I6d6d7b357e06a8c3218a98d702854b2b21661482
Reviewed-on: https://chromium-review.googlesource.com/707349
Commit-Queue: Sharu Jiang <katesonia@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/bdf91f698b5669dc77a6aa7255fc6672525aa3fa/appengine/predator/app/common/test/predator_app_test.py
[modify] https://crrev.com/bdf91f698b5669dc77a6aa7255fc6672525aa3fa/appengine/predator/app/common/model/crash_analysis.py
[modify] https://crrev.com/bdf91f698b5669dc77a6aa7255fc6672525aa3fa/appengine/predator/app/common/predator_for_clusterfuzz.py
[modify] https://crrev.com/bdf91f698b5669dc77a6aa7255fc6672525aa3fa/appengine/predator/app/common/model/log.py
[modify] https://crrev.com/bdf91f698b5669dc77a6aa7255fc6672525aa3fa/appengine/predator/app/common/predator_app.py
[modify] https://crrev.com/bdf91f698b5669dc77a6aa7255fc6672525aa3fa/appengine/predator/app/common/test/predator_for_clusterfuzz_test.py
[modify] https://crrev.com/bdf91f698b5669dc77a6aa7255fc6672525aa3fa/appengine/predator/app/common/test/predator_for_chromecrash_test.py

Sign in to add a comment