New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772571 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 781459



Sign in to add a comment

MD Extensions: in error-console, clicking on the error item should not show focus line.

Project Member Reported by scottchen@chromium.org, Oct 6 2017

Issue description

focus line should only be shown when focused by keyboard. clicking on it should just select it directly and not show the focus state.
 
Screenshot from 2017-10-06 11:12:07.png
54.3 KB View Download
FYI the FocusOutlineManager class can be used to deal with this problem, see [1] and an example at [2]


[1] https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/focus_outline_manager.js
[2] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js?l=94
Owner: catmulli...@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Owner: dpa...@chromium.org
Blockedon: 781459
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce67f79b1082968e5a0597572837cd6de6edcb9e

commit ce67f79b1082968e5a0597572837cd6de6edcb9e
Author: dpapad <dpapad@chromium.org>
Date: Fri Nov 10 02:17:08 2017

MD Extensions: Fix FocusOutlineManager to work for Shadow DOM.

FocusOutlineManager previously deferred updating the focus-outline-visible
CSS class until a 'focus' event was received. This does not work in Shadow DOM,
since 'focus' events do not reach the top level document element. Updating
focus-outline-visible CSS class when a mouse or keyboard event occurs fixes the issue.

Note: This slightly changes the behavior of FocusOutlineManager when
1) an element is focused by keyboard
2) while the element is focused the user clicks on it.

Before, the focus outline would remain visible (introduced at crrev.com/22521002/).
After, clicking on an element that already shows the outline will remove the outline.

Bug:  772571 , 781459 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie233c212fd17724ca8a43e46eb51398612644331
Reviewed-on: https://chromium-review.googlesource.com/749887
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515424}
[modify] https://crrev.com/ce67f79b1082968e5a0597572837cd6de6edcb9e/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/ce67f79b1082968e5a0597572837cd6de6edcb9e/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/ce67f79b1082968e5a0597572837cd6de6edcb9e/chrome/browser/resources/md_extensions/error_page.js
[modify] https://crrev.com/ce67f79b1082968e5a0597572837cd6de6edcb9e/ui/webui/resources/js/cr/ui/focus_outline_manager.js

Comment 8 by dpa...@chromium.org, Nov 10 2017

Status: Fixed (was: Started)

Sign in to add a comment