MD Extensions: in error-console, clicking on the error item should not show focus line. |
||||||
Issue descriptionfocus line should only be shown when focused by keyboard. clicking on it should just select it directly and not show the focus state.
,
Oct 13 2017
,
Oct 30 2017
,
Nov 2 2017
,
Nov 3 2017
FYI, candidate fix is at https://chromium-review.googlesource.com/c/chromium/src/+/749887.
,
Nov 3 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce67f79b1082968e5a0597572837cd6de6edcb9e commit ce67f79b1082968e5a0597572837cd6de6edcb9e Author: dpapad <dpapad@chromium.org> Date: Fri Nov 10 02:17:08 2017 MD Extensions: Fix FocusOutlineManager to work for Shadow DOM. FocusOutlineManager previously deferred updating the focus-outline-visible CSS class until a 'focus' event was received. This does not work in Shadow DOM, since 'focus' events do not reach the top level document element. Updating focus-outline-visible CSS class when a mouse or keyboard event occurs fixes the issue. Note: This slightly changes the behavior of FocusOutlineManager when 1) an element is focused by keyboard 2) while the element is focused the user clicks on it. Before, the focus outline would remain visible (introduced at crrev.com/22521002/). After, clicking on an element that already shows the outline will remove the outline. Bug: 772571 , 781459 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie233c212fd17724ca8a43e46eb51398612644331 Reviewed-on: https://chromium-review.googlesource.com/749887 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515424} [modify] https://crrev.com/ce67f79b1082968e5a0597572837cd6de6edcb9e/chrome/browser/resources/md_extensions/compiled_resources2.gyp [modify] https://crrev.com/ce67f79b1082968e5a0597572837cd6de6edcb9e/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/ce67f79b1082968e5a0597572837cd6de6edcb9e/chrome/browser/resources/md_extensions/error_page.js [modify] https://crrev.com/ce67f79b1082968e5a0597572837cd6de6edcb9e/ui/webui/resources/js/cr/ui/focus_outline_manager.js
,
Nov 10 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Oct 6 2017