perf dashboard ip whitelist should be sorted |
||
Issue descriptionCurrently it isn't, and that makes maintaining it harder (to see if entries should be there or not). I have just manually sorted it and updated it, but ideally the tool would do it for us. If someone points me at the code, I can fix it.
,
Oct 6 2017
Should be via https://github.com/catapult-project/catapult/blob/master/dashboard/dashboard/edit_site_config.py, likely _FormatJson at the bottom. Not sure if we wanna just blanket add sorting to every list, but I'm not opposed to checking if it's 'ip_whitelist'. Annie, any other ideas?
,
Oct 9 2017
I agree it should be sorted in the location listed in #2, but not sure how important this is given that we're focused on switching to service accounts?
,
Jan 10
Archiving P3s older than 1 year with no owner or component. |
||
►
Sign in to add a comment |
||
Comment 1 by dpranke@chromium.org
, Oct 6 2017