mash: Crash opening item in app list |
||||
Issue descriptionmash: Crash opening item in app list On ToT @ #506761 (1) Run chrome --mash (2) Open the app list (3) Try to click on an item in the lower part of the grid (eg. Files) Expected: Item opens Actual: Crash, stack below. [190487:190487:1006/151751.808866:FATAL:apps_grid_view.cc(372)] Check failed: !drag_view_. #0 0x7f53fa30dc3c base::debug::StackTrace::StackTrace() #1 0x7f53fa333b1c logging::LogMessage::~LogMessage() #2 0x7f53f47e4f92 app_list::AppsGridView::~AppsGridView() #3 0x7f53f47e557e app_list::AppsGridView::~AppsGridView() #4 0x7f53f53e0ad4 views::View::~View() #5 0x7f53f47e35f4 app_list::AppsContainerView::~AppsContainerView() #6 0x7f53f53e0ad4 views::View::~View() #7 0x7f53f47eda8e app_list::ContentsView::~ContentsView() #8 0x7f53f53e0ad4 views::View::~View() #9 0x7f53f47dd2e5 app_list::AppListMainView::~AppListMainView() #10 0x7f53f53e1b80 views::View::DoRemoveChildView() #11 0x7f53f53e2215 views::View::RemoveAllChildViews() #12 0x7f53f47de570 app_list::AppListView::~AppListView() #13 0x7f53f47de73e app_list::AppListView::~AppListView() #14 0x7f53f53f1d25 views::Widget::OnNativeWidgetDestroyed() #15 0x7f53f5408368 views::DesktopNativeWidgetAura::OnHostClosed() #16 0x7f53f490384b views::DesktopWindowTreeHostMus::CloseNow() #17 0x7f53f49054c7 _ZN4base8internal7InvokerINS0_9BindStateIMN5views24DesktopWindowTreeHostMusEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #18 0x7f53fa30e4cf base::debug::TaskAnnotator::RunTask() #19 0x7f53fa33e959 base::internal::IncomingTaskQueue::RunTask() #20 0x7f53fa340c03 base::MessageLoop::RunTask() #21 0x7f53fa34132e base::MessageLoop::DoWork() #22 0x7f53fa343bc9 base::MessagePumpLibevent::Run() #23 0x7f53fa340712 base::MessageLoop::Run() #24 0x7f53fa3746af base::RunLoop::Run() #25 0x55aa9c3aff6a ChromeBrowserMainParts::MainMessageLoopRun() #26 0x7f53f7787a57 content::BrowserMainLoop::RunMainMessageLoopParts() #27 0x7f53f778a436 content::BrowserMainRunnerImpl::Run() #28 0x7f53f77832af content::BrowserMain() #29 0x7f53f800a7fc content::ContentMainRunnerImpl::Run() #30 0x7f53fa8561be service_manager::Main() #31 0x7f53f80091e4 content::ContentMain() #32 0x55aa9b9bb81b ChromeMain #33 0x7f53ee301f45 __libc_start_main #34 0x55aa9b9bb642 <unknown>
,
Oct 9 2017
Fixed in my CL which is under review. It also fixes https://bugs.chromium.org/p/chromium/issues/detail?id=766406#c7
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bd87aad03fecf0e21a6289410d9fd202685f2d9 commit 3bd87aad03fecf0e21a6289410d9fd202685f2d9 Author: Alex Newcomer <newcomer@chromium.org> Date: Tue Oct 10 16:17:20 2017 cros-mash: Fixed crashing AppList on app launch Removed check in SetMouseDragging which was causing drag_view_ to be initialized on AppsGridView destruction. This CL also fixes https://bugs.chromium.org/p/chromium/issues/detail?id=766406#c7 Bug: 772563 Change-Id: Ie66bd1dd13c713b3a3585957dc34e9a972221314 Reviewed-on: https://chromium-review.googlesource.com/706547 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#507682} [modify] https://crrev.com/3bd87aad03fecf0e21a6289410d9fd202685f2d9/ui/app_list/views/app_list_item_view.cc [modify] https://crrev.com/3bd87aad03fecf0e21a6289410d9fd202685f2d9/ui/app_list/views/app_list_item_view.h
,
Oct 10 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by newcomer@chromium.org
, Oct 7 2017Owner: newcomer@chromium.org
Status: Started (was: Available)