New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772560 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refresh types never used on TaskManagerTableModel

Project Member Reported by erikc...@chromium.org, Oct 6 2017

Issue description

Comment 1 by nick@chromium.org, Oct 6 2017

My understanding is that the RetrieveSavedColumnsSettingsAndUpdateTable() should correctly set the refresh types based on the visible columns.

I agree with the observation that the refresh types passed into the TaskManagerTableModel seem to be unnecessary, and can be removed. 
Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20893ab9a294053d7ff10a4a17cb148aeb51545a

commit 20893ab9a294053d7ff10a4a17cb148aeb51545a
Author: erikchen <erikchen@chromium.org>
Date: Mon Oct 09 18:42:11 2017

Remove unused argument from TaskManagerTableModel constructor.

The refresh types are determined by visible columns in
RetrieveSavedColumnsSettingsAndUpdateTable. The refresh types passed in the
constructor for TaskManagerTableModel have no effect.

Bug:  772560 
Change-Id: I0eee9449c30d90a596cb80e435293becd0579116
Reviewed-on: https://chromium-review.googlesource.com/706347
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507426}
[modify] https://crrev.com/20893ab9a294053d7ff10a4a17cb148aeb51545a/chrome/browser/ui/cocoa/task_manager_mac.h
[modify] https://crrev.com/20893ab9a294053d7ff10a4a17cb148aeb51545a/chrome/browser/ui/cocoa/task_manager_mac.mm
[modify] https://crrev.com/20893ab9a294053d7ff10a4a17cb148aeb51545a/chrome/browser/ui/task_manager/task_manager_table_model.cc
[modify] https://crrev.com/20893ab9a294053d7ff10a4a17cb148aeb51545a/chrome/browser/ui/task_manager/task_manager_table_model.h
[modify] https://crrev.com/20893ab9a294053d7ff10a4a17cb148aeb51545a/chrome/browser/ui/views/task_manager_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment