New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772552 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug

Blocking:
issue 707031



Sign in to add a comment

Port content_shell, and content_browsertests, to Fuchsia

Project Member Reported by w...@chromium.org, Oct 6 2017

Issue description

Get content_ shell and browsertests working under Fuchsia.
 

Comment 1 by w...@chromium.org, Oct 6 2017

Blocking: 707031
crbug.com/769478 too. Maybe this one could be content_shell.

Comment 3 by w...@chromium.org, Oct 25 2017

Labels: -Pri-3 M-64 Pri-2
Owner: w...@chromium.org
Status: Started (was: Untriaged)
Working to land the changes necessary for content_shell to build.

Comment 4 by w...@chromium.org, Oct 26 2017

Cc: kmarshall@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a750f6b5df4c79c4673e472d1c9b8911a1e68282

commit a750f6b5df4c79c4673e472d1c9b8911a1e68282
Author: Wez <wez@chromium.org>
Date: Thu Oct 26 16:37:42 2017

Only define ContentMainDelegate::Zygote* functions under Linux.

Chromium only uses a "Zygote" process under Linux, but was defining the
ZygoteStarting and ZygoteForked functions for embedders to override for
all OS_POSIX, except Mac & Android. Rather than adding Fuchsia to the
list of exceptions, just fix the definitions to exist only under Linux.

Bug:  772552 
Change-Id: I5d5ede023057c0c52cef29dbb2f79a5185681630
Reviewed-on: https://chromium-review.googlesource.com/738858
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511847}
[modify] https://crrev.com/a750f6b5df4c79c4673e472d1c9b8911a1e68282/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/a750f6b5df4c79c4673e472d1c9b8911a1e68282/chrome/app/chrome_main_delegate.h
[modify] https://crrev.com/a750f6b5df4c79c4673e472d1c9b8911a1e68282/content/app/content_main_runner.cc
[modify] https://crrev.com/a750f6b5df4c79c4673e472d1c9b8911a1e68282/content/public/app/content_main_delegate.cc
[modify] https://crrev.com/a750f6b5df4c79c4673e472d1c9b8911a1e68282/content/public/app/content_main_delegate.h
[modify] https://crrev.com/a750f6b5df4c79c4673e472d1c9b8911a1e68282/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/a750f6b5df4c79c4673e472d1c9b8911a1e68282/content/shell/app/shell_main_delegate.h
[modify] https://crrev.com/a750f6b5df4c79c4673e472d1c9b8911a1e68282/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/a750f6b5df4c79c4673e472d1c9b8911a1e68282/headless/lib/headless_content_main_delegate.h

Comment 6 by w...@chromium.org, Oct 26 2017

Also landed https://chromium-review.googlesource.com/c/chromium/src/+/737058 which gets content_shell building, but forgot this bug # in the CL description.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2017

Comment 8 by w...@chromium.org, Oct 30 2017

Status: Fixed (was: Started)
Closing this out since the targets _build_ for Fuchsia; will repurpose issue 769478 for content_browsertests actually running in a meaningful way.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51b93f4d5c60606a986af6d8614153eeee3cb1a3

commit 51b93f4d5c60606a986af6d8614153eeee3cb1a3
Author: Evgene Gubernatorov <eugenebng@yandex-team.ru>
Date: Thu Nov 30 18:26:49 2017

Small fix for crrev.com/c/738858.

R=wez@chromium.org,rsesek@chromium.org
Bug:  772552 

Change-Id: I666f2ae1ea4a423250b53715b2957d3a87165935
Reviewed-on: https://chromium-review.googlesource.com/787891
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520613}
[modify] https://crrev.com/51b93f4d5c60606a986af6d8614153eeee3cb1a3/chrome/app/chrome_main_delegate.cc

Sign in to add a comment