These targets should depend on a common set of deps, and share source where applicable, so that deps changes don't have to be made in two spots to avoid breaks.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bc3b8b6c607ef6d49d060c00da5205a88709656 commit 3bc3b8b6c607ef6d49d060c00da5205a88709656 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Oct 17 16:53:17 2017 [vr] Measure text render speed in GTest This change also adds a new target for performance tests in VR and a target for dependencies shared among vr test targets. Bug: 772551 , 774636 Change-Id: I7de0cd8a5fcba3e71358625c1f3ebfb9bab49fba Reviewed-on: https://chromium-review.googlesource.com/703690 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#509419} [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/BUILD.gn [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/elements/text.cc [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/elements/text.h [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/test/constants.h [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/test/ui_scene_manager_test.cc [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/testapp/BUILD.gn [add] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/text_perftest.cc [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/ui_pixeltest.cc [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/ui_scene_manager_unittest.cc [modify] https://crrev.com/3bc3b8b6c607ef6d49d060c00da5205a88709656/chrome/browser/vr/vr_gl_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c106c242d4edf0a1ce5f6a14cee51094c279ae13 commit c106c242d4edf0a1ce5f6a14cee51094c279ae13 Author: Jonathan Ross <jonross@chromium.org> Date: Tue Oct 17 17:55:49 2017 Revert "[vr] Measure text render speed in GTest" This reverts commit 3bc3b8b6c607ef6d49d060c00da5205a88709656. Reason for revert: <INSERT REASONING HERE> Original change's description: > [vr] Measure text render speed in GTest > > This change also adds a new target for performance tests in VR > and a target for dependencies shared among vr test targets. > > Bug: 772551 , 774636 > Change-Id: I7de0cd8a5fcba3e71358625c1f3ebfb9bab49fba > Reviewed-on: https://chromium-review.googlesource.com/703690 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509419} TBR=vollick@chromium.org,sky@chromium.org,leilei@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Change-Id: I024ea3fdb07bcf76fa1bdd50e235cc69dee00fa7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772551 , 774636 Reviewed-on: https://chromium-review.googlesource.com/723748 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#509427} [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/BUILD.gn [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/elements/text.cc [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/elements/text.h [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/test/constants.h [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/test/ui_scene_manager_test.cc [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/testapp/BUILD.gn [delete] https://crrev.com/633c9bace37614db8a808da3005657a17bf13f9e/chrome/browser/vr/text_perftest.cc [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/ui_pixeltest.cc [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/ui_scene_manager_unittest.cc [modify] https://crrev.com/c106c242d4edf0a1ce5f6a14cee51094c279ae13/chrome/browser/vr/vr_gl_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/213a4220035a59463c56db9c2a118d892713276a commit 213a4220035a59463c56db9c2a118d892713276a Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Oct 17 20:13:44 2017 Reland "[vr] Measure text render speed in GTest" This is a reland of 3bc3b8b6c607ef6d49d060c00da5205a88709656 Original change's description: > [vr] Measure text render speed in GTest > > This change also adds a new target for performance tests in VR > and a target for dependencies shared among vr test targets. > > Bug: 772551 , 774636 > Change-Id: I7de0cd8a5fcba3e71358625c1f3ebfb9bab49fba > Reviewed-on: https://chromium-review.googlesource.com/703690 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509419} TBR=vollick@chromium.org,sky@chromium.org,leilei@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Bug: 772551 , 774636 Change-Id: I833e6dba30885fb7a902ac222614e8ab97f9f874 Reviewed-on: https://chromium-review.googlesource.com/723726 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509500} [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/BUILD.gn [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/elements/text.cc [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/elements/text.h [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/test/constants.h [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/test/ui_scene_manager_test.cc [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/testapp/BUILD.gn [add] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/text_perftest.cc [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/ui_pixeltest.cc [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/ui_scene_manager_unittest.cc [modify] https://crrev.com/213a4220035a59463c56db9c2a118d892713276a/chrome/browser/vr/vr_gl_util_unittest.cc
Comment 1 by tiborg@chromium.org
, Oct 13 2017Owner: tiborg@chromium.org
Status: Started (was: Assigned)